v2.2.0 does not read or write tags anymore about gutentag HOT 6 CLOSED

I'm struggling a little to get it running locally (seems the bundled ffi and sassc-rails don't play nicely with MRI 2.5.0 - at least on my machine - and sass-rails complains about some of the variables syntax. Which version of Ruby are you using? Though I see Travis is happy enough getting that far…)

Using sass-rails I can at least run a Rails console though, and my tests with your branch are working fine (though my tests are certainly pretty simple)… in what way is tag_list not working? Certainly keen to reproduce the issue in full locally.

I actually don't see a need to call super here. What was the reason for this?

Prior to 2.2.0, taggable models didn't include tag_names in their list of model changes (i.e. location.changes etc) - and part of making this work in modern versions of Rails meant calling through to the underlying method implementation provided by the attribute class method. Previously, tag_names was just stored as a simple array in an instance variable.

from gutentag.

Oh, I see, the issue's more in tag_names than tag_names=. Hmm, okay, will investigate further.

from gutentag.

Okay, I think I've got a fix sorted. Can you try the latest in the master branch to confirm (and if it's all green for you, then I'll get a new gem release out):

gem 'gutentag', '~> 2.2.0',
  git:    'https://github.com/pat/gutentag.git',
  branch: 'master'

from gutentag.

BTW, this fix should ensure tag_names works, and you should also be able to override tag_names= with your custom behaviour as well :)

from gutentag.

@pat it's working! Thanks for the help.

from gutentag.

Excellent - I just released v2.2.1 with the fix.

from gutentag.