Global or Router pending component about yrv HOT 13 CLOSED

Maybe in case of nested routers and a solution for <Router pending={Loading}/> we can avoid repetition of pending... for sub-routers...

from yrv.

Sounds fair, the same as exact from top-level routers.

My only concern on inheriting stuff from routers is keeping the context safe, e.g.

<Router exact>
  <Route a />
  <Route b />
  <Router>
    <Route c />
  </Router>
</Router>

The nested-router here should not inherit the exact down to its routes or it should? 🤔

So, a and b are exact routes, but c should be exact too or not?

from yrv.

I think every Router should inherit from parent but can set its context.

Is it wrong?

from yrv.

Is it wrong?

I'm not sure, but think about this: imagine you don't known that the top-level router is exact, and you mount some routes somewhere else inside its context.

You put some routes that are not exact, but suddendly they behave as exact, because its parent router inherited the exact prop from the top-level router.

Do you think that is completely expected?

IMHO I would not inherit from router to router, only routes should inherit stuff from its parent-router, and nothing else — that makes perfect sense to me.

from yrv.

IMHO I would not inherit from router to router, only routes should inherit stuff from its parent-router, and nothing else — that makes perfect sense to me.

Makes sense. Go with it! :)

from yrv.

In theory I have some code that would work for this issue. I simply cannot get your testing setup to work for me no matter what computer I try it on though, so I'm unsure if I a breaking anything.

from yrv.

@jhechtf please rebase again from the master branch, after that you can make ci to run all the tests in your computer, or just wait for github actions to complete. Thank you!

from yrv.

@pateketrueke I rebased the commit some time ago (during thanksgiving break), but as I've said I'm unable to run unit tests in the repository so I cannot attempt to make unit tests to see if my fix does what is intended for this ticket.

from yrv.

Really there is no way to run the test suite in your system? I'm intrigued, please share the logs to see what's happening.

from yrv.

Depending on which environment I use,

ERROR Unable to find the browser. "chrome:headless" is not a browser alias or path to an executable file.

Type "testcafe -h" for help.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test:e2e: `cross-env BASE_URL=http://localhost:3000 testcafe ${BROWSER:-chrome:headless} "-a" "npm run dev" "e2e/cases" "--color"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test:e2e script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jhecht/.npm/_logs/2020-12-05T09_03_26_373Z-debug.log
npm ERR! Test failed.  See above for more details.
make: *** [Makefile:9: ci] Error 1

is the farthest it goes. otherwise it stops way before that.

from yrv.

So, you don't have Chrome installed? Try another browser instead, e.g. make ci BROWSER=chromium:headless or make ci BROWSER=firefox or make ci BROWSER=safari, etc.

from yrv.

I don't do work on a Linux distribution, so neither of these solutions work for me.

from yrv.

Do you have access to Docker?

from yrv.