Comments (10)
tiagopazhs
commented on August 11, 2024
1
Hi Guys,
I was wondering if this has safari support to? I've tried to implement it on a website, and on safari I'm getting a strange repeated background image and i don't see any play button, I also can't click the video to let it play.
Thanks in advance!
grts
Now it is working on lite-youtube-embed v0.3.2
from lite-youtube-embed.
JuanitoFatas
commented on August 11, 2024
What's your Safari version? Works for me with Safari 13.0.3 (15608.3.10.1.4) on macOS 10.15.1.
from lite-youtube-embed.
geoffreyvandamme
commented on August 11, 2024
My safari version is 12.0.3 on macOS 10.14.3
Also, tried it on IE11, and there it's also not working, it's like the
script doesn't get runned
grts,
G
…On Tue, Nov 26, 2019 at 12:25 PM Juanito Fatas ***@***.***> wrote:
What's your Safari version? Works for me with Safari 13.0.3
(15608.3.10.1.4) on macOS 10.15.1.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21?email_source=notifications&email_token=AEALYJYLWBXW45S5RYREM5LQVUBTDA5CNFSM4JRVZCK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFFVWIQ#issuecomment-558586658>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEALYJYHUTBGFUGV3WIA4GDQVUBTDANCNFSM4JRVZCKQ>
.
--
Geoffrey Vandamme | *Zaakvoerder*
Email: [email protected] | GSM: +32 497 85 94 06
from lite-youtube-embed.
JuanitoFatas
commented on August 11, 2024
Oh 😞
Does the console throw any error related to this? Is it possible to share relevant code or in a sample repository to try?
Thank you!
from lite-youtube-embed.
geoffreyvandamme
commented on August 11, 2024
I don't see any console errors, i'm gonna try to explain the usecase as
good as possible:
I'm using this npm package to include the library:
https://www.npmjs.com/package/@justinribeiro/lite-youtube
I want to use it in the projects javascript so i followed the steps
described here to include it.
import '@justinribeiro/lite-youtube';
In chrome and firefox, everything is working fine, and the dom get's
adjusted by the script:
[image: Screenshot 2019-11-26 at 13.28.59.png]
In safari though, the script doesn't seem to include the right dom elements:
[image: Screenshot 2019-11-26 at 13.30.21.png]
I realize that this npm package is probably made by somebody else, so i
issued it on this github page to!
grts,
G
(I'll try to set up a test-repo when i have some more time for this ;) )
…On Tue, Nov 26, 2019 at 12:54 PM Juanito Fatas ***@***.***> wrote:
Oh 😞
Does the console throw any error related to this? Is it possible to share
relevant code or in a sample repository to try?
Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21?email_source=notifications&email_token=AEALYJYDPMLETTWIQXASHBTQVUE7ZA5CNFSM4JRVZCK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFFX5NY#issuecomment-558595767>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEALYJ54FCTFHSVZZ27PTZ3QVUE7ZANCNFSM4JRVZCKQ>
.
--
Geoffrey Vandamme | *Zaakvoerder*
Email: [email protected] | GSM: +32 497 85 94 06
from lite-youtube-embed.
Garbee
commented on August 11, 2024
IE has no support for custom elements. Current versions of Edge have some level of support though. Safari... It's working here in the latest version for MacOS Catalina. Apple only has partial support for Custom Elements however, so it could be their implementation being buggy. (Or possibly their anti-tracking/privacy stuff?)
We should do a quick look into where this currently works and document that. Then decide how far we want to push support on it. Thanks for pointing this out.
from lite-youtube-embed.
Garbee
commented on August 11, 2024
Oh, and i just looked into that package you're using... It is from Justin Ribeiro. Great guy, but he has done a bit of work on top including using Shadow DOM to encapsulate the element. His repository is here: https://github.com/justinribeiro/lite-youtube . So if you are using that package and wish to keep using it, you should probably head over there for better support.
from lite-youtube-embed.
paulirish
commented on August 11, 2024
it was reported at justinribeiro/lite-youtube#3
and @justinribeiro fixed it in justinribeiro/lite-youtube#4
from lite-youtube-embed.
Rahul-Sam
commented on August 11, 2024
@paulirish Hi, this is not supporting ie and edge. I am looking for your help on the same.
from lite-youtube-embed.
Garbee
commented on August 11, 2024
Internet Explorer does not and never will support custom elements. So this will simply not work there unless you pull in polyfills. Which we do not guarantee they will even necessarily work.
Edge it should work. Please file a specific issue for what exactly isn't working with reproduction steps. (Granted, Edge has recently switched to being Chromium based. So if Irish follows other projects in supporting the "last two major versions" then very quickly Edge will function very similarly to Chrome, if not exact.)
from lite-youtube-embed.
Related Issues (20)
- Failed to execute 'postMessage' HOT 2
- Type declarations
- On mobile, double click is neccesary HOT 8
- Display a title on the video thumbnail HOT 2
- Graceful degradation if YT API breaks
- NPM version is outdated HOT 1
- Custom Width and Height for Youtube shorts HOT 6
- Will it be counted as views on YouTube? HOT 2
- sometime no image loaded HOT 1
- does not work on mobile HOT 2
- Early click on Progressively Enhanced version directs user to youtube.com HOT 1
- A11Y: Why `a.lty-playbtn` instead of `button`? HOT 2
- Start and end params not working when using js-api
- I am using lite youtube embed and I want to get onStateChange player.getPlayerState():
- How can we keep the lower quality preview?
- Could we get a more noob friendly guide for Pro-usage? 😇
- Deprecated navigator.vendor HOT 1
- v0.3.2 Release HOT 1
- Yield on LiteYTEmbed click listener to reduce INP impact HOT 3
- Offering the class in ESM format
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lite-youtube-embed.