Make it ES5 compliant about lite-youtube-embed HOT 10 CLOSED

I would not publish custom elements as ES5. Since custom elements extend HTMLElement and must do a proper super() constructor call, they can't actually easily be compiled to ES5 class patterns. If you do, you'll need to include something like the custom-elements-es5-adapter from the web components polyfills, which can slow down all custom elements on the page.

It's much better to let consumers compile to old JS if they need to for their browser support requirements.

from lite-youtube-embed.

could this not be handled by babel if required?

from lite-youtube-embed.

It could, yeah, but we shouldn't make things more complex :)

I mean, if we can do without babel, it'd be better.

from lite-youtube-embed.

it's been a while since i've published web-facing JS... are there any tools I can use to validate my npm package is es5-compliant?

from lite-youtube-embed.

There was an ESLint plugin, but I didn't have the best experience when I used it a long time ago. So maybe now it's been improved https://www.npmjs.com/package/stylelint-no-unsupported-browser-features

That being said, since the code isn't much, I can help if you need me. The .browserslistrc approach is the safest one, though, so that we have autoprefixer also if needed later. Although, from a quick look, the CSS is quite simple, so maybe only the JS part needs some love :)

from lite-youtube-embed.

Err, I meant https://github.com/amilajack/eslint-plugin-compat

from lite-youtube-embed.

Actually, scratch that. I don't think ES5 is needed https://caniuse.com/#feat=custom-elementsv1, right?

In that case, maybe there should be some feature checking?

from lite-youtube-embed.

Yea, ES6 is required to properly publish Web Components. Distributing something older hinders the integration and performance.

Why did you initially request ES5 compatibility? What was the driving context that deemed ES5 a necessity?

from lite-youtube-embed.

I hadn't actually read the code :)

from lite-youtube-embed.

it's been a while since i've published web-facing JS

Welcome back @paulirish 😄

from lite-youtube-embed.