Giter VIP home page Giter VIP logo

Comments (5)

shawnfromportland avatar shawnfromportland commented on August 11, 2024 3

@Stanzilla @paulirish simply commenting out this line in source allowed my lite-youtube-embed's to work perfectly in my particular layout. I attempted to override that style in my own stylesheet loaded afterwards with:

lite-youtube {
    max-width: none !important;
}

or

lite-youtube {
    max-width: 100% !important;
}

but neither solution worked and the embed was still limited to 750px.

for now i will run lite-youtube-embed with the commented out source line 9 indicated above.

from lite-youtube-embed.

paulirish avatar paulirish commented on August 11, 2024

hmmmm... i don't see a reason why lite-youtube { max-width: none !important;} wouldn't work. it should.

i added this style not too long ago because it was HUGE on my test pages. and that seemed wasteful.

but i agree if someone can't clear that max-width then we have problems.

from lite-youtube-embed.

paulovieira avatar paulovieira commented on August 11, 2024

I was able to override lite-youtube { max-width: ... } without any problem.

Still, I agree with @Stanzilla that a video embed should have 100% width by default. I think that would be a better developer experience.

What about changing those test pages so that the embeds are inside a small container?

from lite-youtube-embed.

srflp avatar srflp commented on August 11, 2024

If using tailwindcss, you can use !max-w-full class on the lite-youtube component to make it responsive

from lite-youtube-embed.

paulirish avatar paulirish commented on August 11, 2024

Still, I agree with @Stanzilla that a video embed should have 100% width by default.

The youtube iframe doesn't do 100% width by default. Therefore this drop-in replacement won't.


The solution to this is a basic style:

lite-youtube {
  max-width: unset;
}

from lite-youtube-embed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.