Giter VIP home page Giter VIP logo

Comments (4)

pauljohanneskraft avatar pauljohanneskraft commented on June 4, 2024 1

Hey - I had a look at this and came up with this preliminary version. I haven't yet had the time to test the code thoroughly and am not entirely sure about the design, but maybe you have some feedback: #33

The PR currently has some more changes that do not necessarily belong in there (e.g. the introduction of UserTrackingMode in favor of MKUserTrackingMode), but I haven't yet found the time to separate into its own PR.

The feature has also been requested in #29

from map.

pauljohanneskraft avatar pauljohanneskraft commented on June 4, 2024 1

Released as part of Map 0.2.0.

from map.

pauljohanneskraft avatar pauljohanneskraft commented on June 4, 2024

Yes, this is an issue of the current implementation. One would need to implement mapView(_:clusterAnnotationForMemberAnnotations:) in Map.Coordinator and implement it accordingly.

I'm not quite sure yet, how MapKit decides which member annotations to cluster and how we could reasonably provide the logic of creating the cluster without requiring another closure in the initializer or it only working for the built-in annotations (which probably the MapKit-SwiftUI approach is at the moment).

In your example, MapMarkers are created using MKMarkerAnnotationViews which probably have some built-in clustering mechanism even in MKMapView.

Would you like to further investigate or add your own thoughts about this? That would be highly appreciated, since I believe this is an important topic that should be approached soon, but I unfortunately do not yet have a full solution in mind.

from map.

pauljohanneskraft avatar pauljohanneskraft commented on June 4, 2024

I have just tried this with the following code and it seems to work perfectly fine:

import Map
import MapKit
import SwiftUI

struct Annotation: Identifiable {

    let id = UUID()
    let coordinate: CLLocationCoordinate2D
    let clusteringIdentifier: String

}

struct ContentView: View {

    @State private var region = MKCoordinateRegion(
        center: .init(latitude: 50, longitude: 10),
        latitudinalMeters: 100_000,
        longitudinalMeters: 100_000
    )

    @State private var annotations = [
        Annotation(coordinate: .init(latitude: 49.5, longitude: 09.5), clusteringIdentifier: "a"),
        Annotation(coordinate: .init(latitude: 49.5, longitude: 10.0), clusteringIdentifier: "a"),
        Annotation(coordinate: .init(latitude: 49.5, longitude: 10.5), clusteringIdentifier: "a"),
        Annotation(coordinate: .init(latitude: 50.0, longitude: 09.5), clusteringIdentifier: "b"),
        Annotation(coordinate: .init(latitude: 50.0, longitude: 10.0), clusteringIdentifier: "b"),
        Annotation(coordinate: .init(latitude: 50.0, longitude: 10.5), clusteringIdentifier: "b"),
        Annotation(coordinate: .init(latitude: 50.5, longitude: 09.5), clusteringIdentifier: "b"),
        Annotation(coordinate: .init(latitude: 50.5, longitude: 10.0), clusteringIdentifier: "b"),
        Annotation(coordinate: .init(latitude: 50.5, longitude: 10.5), clusteringIdentifier: "b"),
    ]


    var body: some View {
        Map(
            coordinateRegion: $region,
            annotationItems: annotations
        ) { annotation in
            ViewMapAnnotation(coordinate: annotation.coordinate, clusteringIdentifier: annotation.clusteringIdentifier) {
                Circle()
                    .fill((annotation.clusteringIdentifier == "a" ? Color.red : .yellow).opacity(0.5))
                    .frame(width: 16, height: 16)
            }
        } clusterAnnotation: { annotation, members in
            let _ = assert(Set(members.map(\.clusteringIdentifier)).count == 1)
            ViewMapAnnotation(annotation: annotation) {
                Circle()
                    .fill((members.first?.clusteringIdentifier == "a" ? Color.blue : .green).opacity(0.5))
                    .frame(width: 16, height: 16)
            }
        }
        .edgesIgnoringSafeArea(.all)
    }
}

from map.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.