Comments (9)
For order items 0
and 1
in your getAllItems()
list, the sku
and productId
are the same, thus I'd say that both items must be included. Or is that a typo? Or maybe I'm not quite understanding.
from magento-2.
Or is that a typo?
Sorry, I updated my post above. Items 1, 3, 5
are skipped as dummy order items in \Payone\Core\Model\Api\Invoice::addProductInfo
.
Additional info: we use
"name": "payone-gmbh/magento-2",
"version": "1.3.5",
from magento-2.
Okay, I see :) Basically, this can be avoided by adding the sku
as an additional condition for adding the product in the \Payone\Core\Model\Api\Invoice::addProductItem
method, right? I'm not quite sure about possible side effects, but we'll check and come back to you.
from magento-2.
Thank you, that should do. Meanwhile I figured out, that in our case the configuration payone_general/invoicing/transmit_enabled = 0
is a suitable workaround for that issue.
from magento-2.
This workaround should work for most payment methods, but be advised that some methods require the transmission of a basket (e.g. factoring providers "safe invoice") and this transmit_enabled flag will be overridden for those.
from magento-2.
#127 is supposed to fix this issue. I can't really test this with our test data - can you confirm this fixes your issue?
from magento-2.
The code looks good to me. Currently I am not able to set up a test scenario either. I'll give an update, as soon as I can test it.
from magento-2.
Works fine for debits now, invoices/capture not explicitly tested as we have a different workflow for that. But debits (Gutschriften) work perfect, thanks.
from magento-2.
Thanks for the feedback!
from magento-2.
Related Issues (20)
- Missing handling of region-codes (Magento/ISO vs. Payone api) HOT 1
- when selecting credit card type showing error HOT 3
- Magento2 dont have option to map paid to processing HOT 1
- Facing multiple issue after integrate payone HOT 3
- Facing multiple issue after integrate payone HOT 1
- PayOne ApplePay compatibility with Magento Cloud HOT 2
- Adding PHP 8.2 support for Magento 2.4.6 release HOT 1
- deprecated _isScopePrivate in Totals.php HOT 3
- Credit card payment after canceling payment process still authorized and order status processing HOT 2
- Add compatibility to PHP 8.2 HOT 2
- Cannot checkout with PayPal Express HOT 6
- Version 3.8.1 : Deprecated Functionality: Function utf8_encode() HOT 8
- Version 3.8.1: Deprecated Functionality: Creation of dynamic property HOT 3
- PayPal Express Button does not respect Minimal Order Amount HOT 1
- Error 923 Payment type not available for this currency or card type Set correct currency, type of payment, type of card, type of account or portalid HOT 3
- Errorcode 1610 - probably rounding error in calculation of order amount HOT 1
- Issue with canceled orders HOT 1
- Random paypal/creditcard orders stuck in status "processing" HOT 1
- Comply with strict CSP ruling in Magento Checkout HOT 2
- Cannot modify readonly property Magento\Framework\HTTP\PhpEnvironment\RemoteAddress::$alternativeHeaders HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento-2.