Giter VIP home page Giter VIP logo

Comments (9)

fjbender avatar fjbender commented on August 18, 2024

For order items 0 and 1 in your getAllItems() list, the sku and productId are the same, thus I'd say that both items must be included. Or is that a typo? Or maybe I'm not quite understanding.

from magento-2.

david-fuehr avatar david-fuehr commented on August 18, 2024

Or is that a typo?

Sorry, I updated my post above. Items 1, 3, 5 are skipped as dummy order items in \Payone\Core\Model\Api\Invoice::addProductInfo.

Additional info: we use

    "name": "payone-gmbh/magento-2",
        "version": "1.3.5",

from magento-2.

fjbender avatar fjbender commented on August 18, 2024

Okay, I see :) Basically, this can be avoided by adding the sku as an additional condition for adding the product in the \Payone\Core\Model\Api\Invoice::addProductItem method, right? I'm not quite sure about possible side effects, but we'll check and come back to you.

from magento-2.

david-fuehr avatar david-fuehr commented on August 18, 2024

Thank you, that should do. Meanwhile I figured out, that in our case the configuration payone_general/invoicing/transmit_enabled = 0 is a suitable workaround for that issue.

from magento-2.

fjbender avatar fjbender commented on August 18, 2024

This workaround should work for most payment methods, but be advised that some methods require the transmission of a basket (e.g. factoring providers "safe invoice") and this transmit_enabled flag will be overridden for those.

from magento-2.

fjbender avatar fjbender commented on August 18, 2024

#127 is supposed to fix this issue. I can't really test this with our test data - can you confirm this fixes your issue?

from magento-2.

david-fuehr avatar david-fuehr commented on August 18, 2024

The code looks good to me. Currently I am not able to set up a test scenario either. I'll give an update, as soon as I can test it.

from magento-2.

sydekumf avatar sydekumf commented on August 18, 2024

Works fine for debits now, invoices/capture not explicitly tested as we have a different workflow for that. But debits (Gutschriften) work perfect, thanks.

from magento-2.

fjbender avatar fjbender commented on August 18, 2024

Thanks for the feedback!

from magento-2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.