Butterfly CLI should allow escaped semicolons and equals as extension property value when passed using -p about butterfly HOT 6 CLOSED

Hello,
I would like to work on this issue.
I am assuming the following scenario-
-pkey1=value1;key2=value2 should return key1 = value1 and key2 = value2
-pkey1=value\;1;key2=value\;2 should return key1 = value;1 and key2 = value;2
-pkey1=value\=1;key2=value\=2 should return key1 = value=1 and key2 = value=2

Please let me know if I am getting it right.

from butterfly.

Hello @badalsarkar
Yes, you got it right.
Thanks!

from butterfly.

Hi @fabiocarvalho777
I have figured out a solution. Changing
try (StringReader stringReader = new StringReader(inlineProperties.replace(';', '\n'))) {

in this file to

try (StringReader stringReader = new StringReader(inlineProperties.replaceAll("(?<!\\\\);", "\n"))) {

should produce the desired result.

But how do I go about testing it? Should I add new test and in which file?

Thanks.

from butterfly.

@badalsarkar please, add a unit test class named ButterflyCliRunnerTest here and add your tests there.

Thanks!!

from butterfly.

@badalsarkar I have just merged your PR. Thank you very much for your contribution :-)

from butterfly.

@fabiocarvalho777 , it was great to contribute. Thank you.

from butterfly.