Giter VIP home page Giter VIP logo

Comments (2)

richardschneider avatar richardschneider commented on July 20, 2024

According to MDM a Date is the number of milliseconds since January 1, 1970, 00:00:00 UTC.

However Date.parse (called by new Date(s)) has changed with respect to date-times without a specified time zone. In earlier versions, it defaulted to UTC. In ECMAScript 2015 it now defaults to the local time one!

Current best practice is to store dates relative to UTC in the database. So should we make this the default for parsing?

I propose adding a dateParse property to the options. It can have following values and defaults to utc:

  • none - do not parse dates
  • utc - assume UTC if time zone is not specified
  • local - assume local time zone if time zone is not specified
  • +hh:mm or '-hh:mm` - assume this offset from UTC if time zone is not specified

from query-to-mongo.

richardschneider avatar richardschneider commented on July 20, 2024

Ok after further investigation, I noticed that the regex for date/time requires a time zone offset. So, new Date(string) is behaving as the code expects.

The tests are wrong. They should be using new Date(Date.UTC(...)) instead of calling the setUTCxxx methods.

from query-to-mongo.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.