Giter VIP home page Giter VIP logo

Comments (7)

youbs avatar youbs commented on June 2, 2024

Can we then just use the methods of the Process class instead of the callback ?

from composer-service.

pborreli avatar pborreli commented on June 2, 2024

it didn't work when i tried, that's why i used the callback

from composer-service.

youbs avatar youbs commented on June 2, 2024

What do you mean? we have getOutput() and getError().
The content is basically the same as we have now (it's just full in case of success).
The first time I added the "logs" feature I removed the callback and juste used those two methods, (I lost it and then redevelopped it since because I'm dumb), and I didn't see something wrong.

from composer-service.

pborreli avatar pborreli commented on June 2, 2024

Imo, for this case the text could be under the composer update tab (in red)
composerupdateerror

from composer-service.

youbs avatar youbs commented on June 2, 2024

Why not in the "Composer output" tab?

from composer-service.

pborreli avatar pborreli commented on June 2, 2024

yes that's what i meant

from composer-service.

staabm avatar staabm commented on June 2, 2024

When the errors are shown in a tab the user needs to switch back to the actual input tab... I think it would be better to have errors and input on one screen without the need to switch between them.. (It could additionally be shown in the output tab)

from composer-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.