Comments (5)
It's my impression that the defaults are used by filebeat regardless of whether they're commented out in the config file, or not there at all. Is there somewhere that this isn't the case, or are you suggesting that we leave default values commented out if they're not needed?
from puppet-filebeat.
I was under the impression that:
Logging: {}
Is not the same as
Logging:
I think if the object is empty it shouldn't be put into the template at all.
from puppet-filebeat.
Right now every option gets created because of how I'm creating the config file as a hash then converting the hash to YAML.
The downside of doing it this way is that there are extra stubs like this that aren't as pretty as they could be, but the upside is that new configuration options are supported without doing any work. If it's particularly bothersome that the extra config is there, you can use the more explicit config template by setting the conf_template
parameter to 'filebeat/filebeat.yml.ruby18.erb'. I'm open to other suggestions if you have any.
At some point I'd like to drop back to one config template if possible, possibly dropping the more future proof template in favor of the Ruby 1.8 one, though it would make the module lag slightly behind with new features. I'll consider this a vote in that column.
from puppet-filebeat.
I've done some very minimal testing, and couldn't tell a difference between Logging: {} and Logging: as far as how defaults are handled. There's a good chance I'm not checking all of the cases that might cause problems though - do you have a case that's behaving differently?
from puppet-filebeat.
I thought it was t working for me but it appears I have been mistaken.
Thanks for double checking on this one
On Sat, 28 May 2016 at 12:07 AM Phil Fenstermacher [email protected]
wrote:
I've done some very minimal testing, and couldn't tell a difference
between Logging: {} and Logging: as far as how defaults are handled.
There's a good chance I'm not checking all of the cases that might cause
problems though - do you have a case that's behaving differently?—
You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub
#27 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA-K-6CEsb8HlKBibcG3o9w6kgF8vUx9ks5qFvqqgaJpZM4IkLCh
.
from puppet-filebeat.
Related Issues (20)
- 7.5+ Common Input Parameters HOT 1
- bump puppet-archive dependency HOT 1
- registry options dont work with Filebeat6
- the modules config is not working properly HOT 1
- Wrong default for registry_path
- versioncmp in params.pp HOT 4
- YAML indent is wrong on parser multipath and tail_files is not valid for filestream HOT 2
- Autodiscover is not available in any tag release HOT 7
- New release HOT 1
- filebeat config pure_hash HOT 2
- Fix operators for windowsOS versioncmp check
- Support for filebeat 8 on windows for validate cmd HOT 1
- wrong tag for release 4.13.0 HOT 2
- Filestream not fully implemented HOT 3
- upgrading filebeat major_version takes multiple puppet runs
- [4.14.0] no support for module enable HOT 1
- json configuration not recognized anymore HOT 5
- update module to be compatible with stdlib 9.x HOT 1
- Allow powershell module 6.0.0?
- puppet-archive version HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-filebeat.