app-tools.build/split-path probably won't work in Windows about pedestal HOT 5 CLOSED

Yes, this seems to fail on Windows.

I think the simplest solution might be to replace (re-pattern File/separator) with something like (Pattern/compile File/separator Pattern/LITERAL), where Pattern is java.util.regex.Pattern. I haven't had a chance to test it, though.

from pedestal.

I'm going to try and put together a patch once I settle in at the airport. I'll call on you windows folks to test things out for me as I won't have a windows machine on hand.

Ryan Neufeld

On Tuesday, March 19, 2013 at 8:32 PM, arosequist wrote:

Yes, this seems to fail on Windows.
I think the simplest solution might be to replace (re-pattern File/separator) with something like (Pattern. File/separator Pattern/LITERAL), where Pattern is java.util.regex.Pattern. I haven't had a chance to test it, though.

—
Reply to this email directly or view it on GitHub (#23 (comment)).

from pedestal.

@arosequist, I have your suggestion on a fork+branch of my own rkneufeld/pedestal. I want to make sure the changes actually work and add some dependency-injection/tests. I have to wait until the weekend though, as I don't have a windows box/vm at work.

from pedestal.

@rkneufeld that fix doesn't work for me - I get a NullPointerException with (Pattern/compile "\\" Pattern/LITERAL)

(re-pattern (Pattern/quote "\\")) works however.

from pedestal.

This should be resolved on master now. If you'd like to immediately pick up this change run lein sub install from the root of the pedestal repository and change any application dependencies to version "0.1.2-SNAPSHOT"

from pedestal.