pedestal-service's default responses are now served as application/octet-stream about pedestal HOT 5 CLOSED

I thought the default used to be text/plain. Are you suggesting that or text/html as the default? I'm for the latter since most of us render html not plain text

from pedestal.

I agree it should be text/html, but regardless, this is a weird bug where a default is being squashed.

from pedestal.

This was a bug that bit me early on, so I am partial to it :-)

As far as I can see, ring.util.response/response is returning an empty header whereas io.pedestal.service.http/html-body is using ring.util.response/content-type to explicitly set the content-type to "text/html;charset=UTF-8". Would it make sense to do the same within ring.util.response/response function (pass it through content-type with a suitable default content-type)?

I know this would work because if I change the definition of home-page this way, the bug ceases to exist:

(defn home-page
  [request]
  (resp/content-type (response "Hello World!") "text/html"))

from pedestal.

I'm going to work on fixing this.

from pedestal.

Regardless of what the default content type should be, I wrote a test (see mention) that fails like so:

expected: (= "text/plain" (get-in response [:headers "Content-Type"]))
  actual: (not (= "text/plain" "application/octet-stream"))

Talking with @timewald it seems like we may need our own implementation of content-type-response. (I should also write a failing test in the ring middlewares test ns when I do that.)

from pedestal.