Giter VIP home page Giter VIP logo

Comments (1)

pedrobcst avatar pedrobcst commented on June 23, 2024

Hey,

Sorry for the late reply.

Indeed we do query by combination of elements instead of querying the list of elements. I do not know remember exactly why I made in this way (the queriers itself where one the first things I coded, and its actually due to a refactor), but I believe it was the following reasons:

  • Few of the providers did not support querying the elements in an inclusive manner for a given number of species. Ie, if you asked elements A,B,C,D up to 4 elements, meaning you want A, AB, ABC etc, one of the providers (or couple, not sure) would give back for AB elements + max 3 for example AB + something else such as EF (sorry if its confusing). For example: If you gave [Sr, Ca, Ba, O] with max to 4, some providers for Sr,Ca for example would give all ternary compounds that has Sr,Ca plus something else. And everything else for all the other possible combinations. The way to circumvent this was to pricesely build up all the possible chemical elements and query the chemical space seperately.

  • I wanted to keep track of the elements combinations for when querying overlapping spaces be able to avoid already downloaded spaces. Thinking back, this is quite pointless since this can be checked after querying.

I believe the queriers can be revisited and remade to be more efficient. Specially, the COD querying should be moved totally to OPTIMADE interface that I believe would give more flexibility. This can be reeinvesitgated, just now I dont have much free time to work on Xerus (sorry!), but any PR I would be glad to review and check. Any other improvemenrts are also welcome!

from xerus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.