Comments (6)
Sounds reasonable, I'll open a PR when it's ready :)
from drone-helm3.
Thanks for the suggestion @obukhov -
since I don't see much reason for having both update_dependencies and build_dependencies, it might be worth changing the settings interface to just dependencies: build or dependencies: update for each situation.
I'll take a look when I get some time otherwise I'm definitely open to a PR if you want to take a stab at it :)
from drone-helm3.
I don't see much reason for having both update_dependencies and build_dependencies
Yeah, I agree they should be exclusive, I was thinking of having priority on Update or throwing an error if both are configured.
worth changing the settings interface to just dependencies: build or dependencies: update
To be honest I don't have a clear understanding of how that should work. The change should be backward compatible, so it should be either new property (and then it is not so beneficial compared to build_dependencies parameter) or the type should be overloaded as "bool | string" which is even worse because it will be "update_dependency: build". The third option would be to have a separate operation for that (and it went different way already in the codebase). What do you think?
I'll take a look when I get some time otherwise I'm definitely open to a PR if you want to take a stab at it :)
It would be interesting for me to do this change, I checked out the source already and it seems pretty straight-forward. If we agree on one solution, I can submit a pull request and we can discuss it further.
from drone-helm3.
Thanks for being willing to contribute: Here's what I was thinking for the implementation to backward support but deprecate update_dependencies.
- I'd say lets keep update_dependencies: but mark it as deprecated:
- Add settings property called dependencies_action: [update or build]
- If update_dependencies: true and dependencies_action set, exit with error stating update_dependencies is deprecated and is not supported with dependencies_action
Totally open on a different property name for the dependencies_action if something else is more clear.
Let me know how that sounds to you. Later on we can remove update_dependencies in a later version :)
from drone-helm3.
@josmo I've added the pull request, please have a look when you have time
from drone-helm3.
Thanks a ton @obukhov ! I just merged it in so it should show up in latest soon. Want to comment on here once you've tried latest and I'll tag a new version?
from drone-helm3.
Related Issues (20)
- Add a new parameter "create_namespace" please
- Upgrade command seems to not use my kube_service_account parameter HOT 2
- Support for private repositories
- How to rollback?
- Update to Helm 3.8.0
- helm test supported?
- exec /bin/drone-helm: no such file or directory HOT 3
- Allow cluster across helm deployment by chart name
- Repo chart name treated as file name on upgrade
- open /root/.kube/config.tpl: permission denie HOT 1
- Does it support publishing of the Helm charts? HOT 5
- error converting YAML to JSON: yaml: line 29: did not find expected key HOT 7
- Question: Help needed on understanding this error HOT 1
- Support for publish to Helm Registry
- force_upgrade is being ignored HOT 2
- Remove build/drone-helm from the repo HOT 1
- Add a comment explaining the purpose env.settingAliases
- Support setting values from files using the --set-file flag
- Support for automatic migrations from v2 using 2to3 HOT 2
- drone-helm3 upgrade failed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drone-helm3.