Giter VIP home page Giter VIP logo

Comments (1)

ErinCall avatar ErinCall commented on June 23, 2024

Currently, there's some code that tries to guess which config fields might show up in the environment section of the consumer's .drone.yml, rather than the settings section. Those fields have to have an envconfig tag, so that envconfig will look for the non-prefixed form if it doesn't see a PLUGIN_ version.

It probably makes more sense to allow all fields to come from a non-prefixed env var. It should be a small change to cmd/drone-helm/main.go. After calling envconfig.Process("plugin", &c), call it again with an empty string for the prefix: envconfig.Process("", &c)

Make sure to confirm that

  1. an empty-string prefix looks for ENV_VAR_NAME, not _ENV_VAR_NAME
  2. if the prefixed form is present, but the non-prefixed form is empty, the second call to envconfig.Process won't stomp on the populated value.

from drone-helm3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.