Add wheels support about django-generic-filters HOT 14 CLOSED

The way we do it usually is by configuring setup.cfg like that: https://github.com/Kinto/kinto-changes/blob/master/setup.cfg

from django-generic-filters.

Wheel packages can be created using: python setup.py bdist_wheel.

from django-generic-filters.

They also can be universal to use the same wheel between py2 and py3 :)

from django-generic-filters.

@Natim It should probably depends on general guidelines for every Python novafloss projects. Would you agree to close this old issue ?

from django-generic-filters.

@Natim I close, re-open it if necessary !

from django-generic-filters.

I didn't get that you wanted to close it without actually fixing it, can I file a pull-request for it?

from django-generic-filters.

@Natim Because it's a very old issue and nobody plans to work on it. But of course you're welcome to submit a PR !

from django-generic-filters.

Ok I just did then :) #50

from django-generic-filters.

@Natim Thanks I'm looking at it

from django-generic-filters.

@Natim Looks good, but I guess we have to wait for #40 and #49 before publishing py3 wheels.

from django-generic-filters.

We won't publish py3 wheels we are pushing an universal one and only people using py2 will use it before merging Py3 support :)

from django-generic-filters.

@Natim I don't understand why we would want to create universal wheel file while the package is not currently universal ? If I refer to http://pythonwheels.com/ :

Note: If your project is python 2 and 3 compatible you can create a universal wheel distribution.

Maybe we could remove the [bdist_wheel] section in the PR ? If so, it would be ok for me to merge. Then we could add it back after #49.

from django-generic-filters.

I believe it depends if you plan on merging #49 before the next release or not...

from django-generic-filters.

@Natim I have to test it. Meanwhile your PR can stay open and I'll merge it when appropriate :-)

from django-generic-filters.