Add tests about pg-magicplan HOT 7 OPEN

I have tested with the PG master regression test. Several tests failed because of the NOTICE and WARNING in the extension, disabling them fixed the 'regressions'.
Does it comfort you? :)

from pg-magicplan.

Well, did you force magic plan? :)

from pg-magicplan.

I did not have to, it triggered for some plans, not for others… so it seemed good to me.

from pg-magicplan.

So it may have not triggered for some plan, and so not tested? The risk is some day it trigger for not tested case?

from pg-magicplan.

It can not trigger for a request that has no EXISTS subquery…

from pg-magicplan.

Tell me if I am wrong how pg-magicplan works. I understand when it sees a query with EXISTS subquery it plans two statements, one with original query, one with OFFSET 0 injected. Then it compare cost and choose to execute the cheapest one.

As we can't know early which plan it will choose, we can't know how PG will behave with OFFSET 0 injected in regression tests. Sometime it will use it sometime no... That's why I propose to force plan with OFFSET 0 in all circumstances for the tests only.

from pg-magicplan.

No I can't. There may be several possible places to inject offset 0, there may be no sublink...

from pg-magicplan.