Capturing a selector instead of a page? about percy-puppeteer HOT 3 CLOSED

Related percy/percy-cypress#56

from percy-puppeteer.

@djones happy to see I'm not the only one taking this route :D. What can I do? I Could see this working as key/value pairs maybe?

percySnapshot(page, 'buttons', {
  elements: {
    containedButtons: '.buttons.contained',
    outlineButtons: '.buttons.outline',
  }
});

from percy-puppeteer.

Left a comment on a related issue: percy/percy-cypress#56 (comment)

Hey everyone! Sadly, this isn't something that is going to be implemented in the near future. It's also not an SDK specific issue (its a product issue) so I'm going to close this (& related issues). Maybe we create a meta repo with a discussion topic for product issues? Not sure (cc @djones)

With that said, this needs to be implemented in the rendering environment, where browsers easily can isolate & capture screenshots of elements (and/or the differ crops to the bounding box of the element). It's a huge rabbit hole trying to capture a subset of the DOM to send to the API for capture. You're going to miss parent>child CSS relationships, have missing assets, collapsed box model issues (when elements rely on sibling/parents for padding/margin), etc. I'm sure if anyone has attempted to use domTransformation, you've noticed it's not cut and dry as plucking a DOM node out of the tree.

from percy-puppeteer.