Comments (5)
Yeah, unit tests would certainly be nice to have. The highest value test would probably be testing the computePrice()
method for all the exchange classes. It would also make contributing easier. I would certainly support adding a library like https://jestjs.io/ to the project.
I'm a fan of TypeScript as well, but a full TypeScript rewrite is probably out of reach at this point. If someone actually did it, I would happily merge it. But it's a big ask, and the fact that all of the exchange classes are totally encapsulated means that types shouldn't be too hard to reason about.
from ethereum-dex-prices-service.
I started digging into the unit tests last night. Aiming to have a PR out in a couple days. 👍
from ethereum-dex-prices-service.
resolved by #15
from ethereum-dex-prices-service.
While writing #8 I ended up debugging some typos that could have easily be avoided if the project was using TypeScript (on a somewhat related note)
from ethereum-dex-prices-service.
Got the first PR out for unit tests. Once this pattern / config is +1'd, I can start on the other exchanges.
from ethereum-dex-prices-service.
Related Issues (17)
- Add support for The Ocean HOT 2
- Introduce new "metadata" field to the result data
- UnhandledPromiseRejectionWarning: Could not connect to socket HOT 7
- Add unit tests for Uniswap HOT 3
- Discussion: Support of the Standard Relayer API (Contract Addresses vs. Symbols) HOT 12
- DEXes APIs HOT 1
- Server Crashing due to timeout HOT 3
- Add support for EthFinex HOT 3
- cli.js require(main) error HOT 1
- Add support for Uniswap HOT 3
- Refactor Ethfinex class HOT 1
- Eth2Dai closed HOT 2
- Oasis moving contracts HOT 1
- Refactor Eth2dai class as OasisTrade class
- Fix RadarRelay class HOT 1
- Add support for ForkDelta HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ethereum-dex-prices-service.