Giter VIP home page Giter VIP logo

Comments (19)

atomrab avatar atomrab commented on June 24, 2024

We left this blank in two cases: when the coverage was unstated but obvious, and when the coverage asserted by the author was also one or more modern nation states (so we could just copy it directly).

I think that you're right, it's probably easiest to copy these over from spatial coverage. But we'll need to be rigorous in the future about differentiating between an explicit statement on the part of the source and an inference, however obvious.

from periodo-data.

rybesh avatar rybesh commented on June 24, 2024

We left this blank in two cases: when the coverage was unstated but obvious, and when the coverage asserted by the author was also one or more modern nation states

Is there any way of reconstructing which of these was the case for the 1207 blanks?

from periodo-data.

atomrab avatar atomrab commented on June 24, 2024

Sort of, by collection. All the Fasti definitions are the latter
(author-asserted), as are PAS, English Heritage, ARENA, Jamieson 2007,
Historiska, Rijksdienst, and Open Context. Pleiades, the UCLA Encyclopedia
of Egyptology and all the values that came in from GeoDia, at least where
spatial coverage label is blank
, are the former (unstated but obvious).
The British Museum values, when they go in, are also the former -- where
there's no label, the coverage was obvious but not explicit.

But that doesn't go item by item. Will it be enough?

Adam

On Wed, Jul 8, 2015 at 12:33 PM, Ryan Shaw [email protected] wrote:

We left this blank in two cases: when the coverage was unstated but
obvious, and when the coverage asserted by the author was also one or more
modern nation states

Is there any way of reconstructing which of these was the case for the
1207 blanks?


Reply to this email directly or view it on GitHub
#24 (comment)
.

from periodo-data.

ptgolden avatar ptgolden commented on June 24, 2024

OK, so:

Author asserted

  • Fasti
  • PAS
  • English Heritage
  • ARENA
  • Jamieson 2007
  • Historiska
  • Rijksdienst
  • Open Context

Unstated but obvious

  • Pleiades
  • UCLA Encyclopedia of Egyptology
  • GeoDia (where coverage is blank)
  • British Museum

The author-asserted values can be immediately copied to the spatialCoverageDescription field. Should the same be done for the unstated-but-obvious values?

More generally, should a spatial coverage description be required for each and every period? If that is the case, it will have consequences for the period form.

from periodo-data.

rybesh avatar rybesh commented on June 24, 2024

should a spatial coverage description be required for each and every period?

I think that the "unstated but obvious" cases should remain without a spatialCoverageDescription so that we aren't putting words in the original source's mouth.

from periodo-data.

atomrab avatar atomrab commented on June 24, 2024

For what it's worth, the entries for Pleiades and the British Museum
already have an editorial note explaining where the spatial coverage came
from. I can also easily add a note for the UEE, since there aren't many
entries and by default it's obviously referring to Egypt.

The same isn't true of the GeoDia entries, but we could add a bulk note to
all those without a description indicating that spatial coverage was
inferred during the GeoDia data entry process.

On Thu, Jul 9, 2015 at 7:42 AM, Ryan Shaw [email protected] wrote:

should a spatial coverage description be required for each and every
period?

I think that the "unstated but obvious" cases should remain without a
spatialCoverageDescription so that we aren't putting words in the
original source's mouth.


Reply to this email directly or view it on GitHub
#24 (comment)
.

from periodo-data.

ptgolden avatar ptgolden commented on June 24, 2024

ok, I'll go ahead and copy spatial coverages over to spatialCoverageDescription for the "author asserted" cases above.

from periodo-data.

ptgolden avatar ptgolden commented on June 24, 2024

I don't see any sources that correspond to English Heritage or Open Context. Are they under different titles, or not in the current "Canonical" dataset?

from periodo-data.

atomrab avatar atomrab commented on June 24, 2024

Sorry, should have been clearer on those. By "English Heritage", I meant the Heritage Data collection (http://n2t.net/ark:/99152/p0kh9ds), which derived the periods we recorded from the English Heritage thesaurus; and by "Open Context" I meant Anderson et al., Digital Index of North American Archaeology (DINAA) (http://n2t.net/ark:/99152/p086kj9).

from periodo-data.

ptgolden avatar ptgolden commented on June 24, 2024

The first batch of fixes is in https://test.perio.do/#/patches/https://test.perio.do/patches/6/. I'll add the other two in another patch.

from periodo-data.

ptgolden avatar ptgolden commented on June 24, 2024

Also the British Museum data can be approved at https://test.perio.do/#/patches/https://test.perio.do/patches/5/

from periodo-data.

atomrab avatar atomrab commented on June 24, 2024

It occurs to me that there is a basic spatial assertion in one of the other unlabeled sources: the spatial element of the Cambridge Companion to the Aegean Bronze Age is "the Aegean". Should I go through and add this to all those values, or can that be done easily as a batch -- or do you guys think it's still too much a stretch in terms of authorial intent, and we should ignore it?

from periodo-data.

ptgolden avatar ptgolden commented on June 24, 2024

do you guys think it's still too much a stretch in terms of authorial intent, and we should ignore it

I think that you're the expert there. If you want me to, I'll add it in my followup patch.

from periodo-data.

atomrab avatar atomrab commented on June 24, 2024

Let's do it. I think it's fair, based on the title of the work.

from periodo-data.

rybesh avatar rybesh commented on June 24, 2024

@atomrab Can I conclude from this discussion that we officially do not require a value for spatialCoverageDescription? If so, I will close this bug and make this clear in the data model documentation and change policy.

from periodo-data.

atomrab avatar atomrab commented on June 24, 2024

from periodo-data.

rybesh avatar rybesh commented on June 24, 2024

I was thinking that it would be fine to not require this (but we should require at least one spatial entity to be specified; see issue #34). Why is the "undefined" value in the filter annoying?

from periodo-data.

atomrab avatar atomrab commented on June 24, 2024

from periodo-data.

rybesh avatar rybesh commented on June 24, 2024

This is a client issue, see periodo/periodo-client#120

from periodo-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.