Giter VIP home page Giter VIP logo

Comments (5)

ptgolden avatar ptgolden commented on July 17, 2024

I assume this won't be retroactively applied to past versions of the dataset (& patches). That means that we will need to write code that deals with both periodCollection/periodCollections and authority/authorities

from periodo-data.

rybesh avatar rybesh commented on July 17, 2024

Is that an argument against doing it, or are you just making an observation?

Also isn't the same true of all the data model changes that aren't strictly additive?

from periodo-data.

rybesh avatar rybesh commented on July 17, 2024

I suppose it would be possible to maintain a set of functions for transforming old invalid data into valid data for display; the changes are all documented at https://github.com/periodo/periodo-validation/tree/master/fix

from periodo-data.

ptgolden avatar ptgolden commented on July 17, 2024

It was an observation. To this point, as far as I can recall, we've only made changes that are additive (in terms of the data model). Checking for periodCollection vs authority would be a good marker for needing to do that sort of conversion.

It's not a big deal with operating on the dataset as a whole-- it'll just get tricky for visualizing diffs whose endpoints cross that threshold. (Not just for this change, but for all of them that we're doing).

from periodo-data.

rybesh avatar rybesh commented on July 17, 2024

Done in staging by https://github.com/periodo/periodo-validation/blob/master/fix/renaming.js

from periodo-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.