Giter VIP home page Giter VIP logo

Comments (8)

ajschmidt8 avatar ajschmidt8 commented on August 17, 2024 1

Peter, thanks for that. The error it returned was 401 Unauthorized. I entered my credentials again into GitHub's secrets and it seems to be working now. I had tried that yesterday, but it's possible I fat-fingered that entry.

Thanks again!

from dockerhub-description.

donalffons avatar donalffons commented on August 17, 2024

I encountered the same problem today (first time after using this action for several months in a slightly different build context)...
Also: Thanks for your work on this, @akloeckner!

from dockerhub-description.

peter-evans avatar peter-evans commented on August 17, 2024

I think this might have been a temporary problem with Docker Hub's API.

This is the part where it calls the API to acquire a token. That token is then masked by the core.setSecret function. This prevents the token from being exposed in the GitHub Actions log.
https://github.com/peter-evans/dockerhub-description/blob/master/src/dockerhub-helper.ts#L14-L20

The error suggests that the API call failed to return a token and the core.setSecret function complained that it was trying to mask an empty string.

I suppose if this becomes a frequent problem I could add some logic to retry the call a few times before failing.

from dockerhub-description.

ajschmidt8 avatar ajschmidt8 commented on August 17, 2024

I'm also experiencing this issue https://github.com/rapidsai/docker/actions/runs/936485269

from dockerhub-description.

ajschmidt8 avatar ajschmidt8 commented on August 17, 2024

It seems to be consistently broken. No amount of retrying the Action results in success.

from dockerhub-description.

peter-evans avatar peter-evans commented on August 17, 2024

@ajschmidt8 I'm pretty sure this is a Docker Hub API problem. I've tested this morning and the action works fine, so please try your workflow again.

Unfortunately, there is probably not a lot I can do to help in this situation. It sounds like you retried a few times and it continued to fail. That means that if I was to add retry logic to the action it wouldn't help much because the downtime on Docker Hub's API was too long.

from dockerhub-description.

peter-evans avatar peter-evans commented on August 17, 2024

I've just made a new release of the action (v2.4.3 / v2) which adds some logic to capture error responses from Docker Hub's API. The action raises an error containing the response from Docker Hub before it tries to extract the token. So you shouldn't see the Warning: Can't add secret mask for empty string log message because it will raise an error before it attempts to mask the token.

Please let me know if you experience errors with the new action version because I'm interested to know exactly what error response Docker Hub is returning for this particular case.

from dockerhub-description.

peter-evans avatar peter-evans commented on August 17, 2024

I'm going to close this issue for now. As I explained above, the latest release now includes capture of the error response returned from the Docker Hub API so if a problem on their side does occur again we should get a clear indication (perhaps a 5xx status code).

from dockerhub-description.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.