Lower down rate for invalid state about hearthstone-ai HOT 9 CLOSED

Move some analyze beforehand

Now we can decide:

1. not enough resource
2. attacker is not attackable
3. hero power is not usable

Still cannot decide:

1. client card cannot be played
2. calient card needs target, but failed
3. GetDefender() return invalid target
4. defender vanished

TODO:

1. no space for minion
2. secret exists

from hearthstone-ai.

TODO:
check simulation failure rate

from hearthstone-ai.

Fixed in commit: 37f9437

from hearthstone-ai.

TODO: when minion is somehow full due to pre-summon triggers,
the minion card should be considered as played successfully, rather than treated as an invalid action.

from hearthstone-ai.

More fixed in commit: f459d1d

from hearthstone-ai.

There are only two possibilities to lead to an invalid state:

1. defender returned by callback is invalid
   a. this is a desired design
2. the card's onplay_handler.PrepareTarget() failed
   a. can we check this beforehand (i.e., in ValidActionGetter)
   b. if we do this check beforehand, but still failed at onplay_handler.PrepareTarget() when doing PlayCard(), we should stop the flow, but returned as a valid state.

from hearthstone-ai.

Need a const version of FlowControl::Manipulate to provide some interfaces to client cards, which allowed client cards to do some checks in onplay_handler.PrepareTarget().
Also, we can fix TODOs in ValidActionGetter.

from hearthstone-ai.

A manipulator, by its name, should be able to manipulate the underlying game state, so adding a const-manipulator doesn't make much sense.

Maybe need to pass const& of game state directly

from hearthstone-ai.

No invalid state anymore.
Fixed in several commits; ending with 5ebc79f.

from hearthstone-ai.