Abstract class for normalizers? about staintools HOT 6 CLOSED

Yes that could make a bit more sense. Call me a python noob but I don't really understand @AbstractMethod yet. Can you enlighten?

from staintools.

I'm on it

from staintools.

Maybe issue should be labelled as a discussion then. By no means I am a specialist. Let me attempt to describe with an example, maybe that would make more sense 💃 However, I can be very wrong

Take Edward for example.. There for each model you have Inference class, however there are just as many inference types as there are models, and you can flexibly glue these together with common sense applied of course. Behind all inference classes, there is a metaclass inference, that implements basic/essential methods, that will be used by all the specific inference types, such as variable initialisation, building a graph and computing. All specific inference types will inherit from that metaclass inference, and will therefore have basic methods already implemented, will have structure enforced upon them, and can be easily plugged in as part of the whole package.

from staintools.

Yes we should do this. Shall I do or are you keen?

from staintools.

Ok I made a develop branch and have attempted to implement this. Do you want to have a look and if you're happy we'll merge :)

from staintools.

Awesome! Just ran on mine, Im sure you've tested it already anyways! I got lost in branches, merge and I will pull from your repo master branch 🤕

from staintools.