Giter VIP home page Giter VIP logo

Comments (2)

peterferguson avatar peterferguson commented on June 27, 2024

Hey thanks for the suggestion, personally I lean towards not doing this.

The library is concerned with creating a unified api for using passkeys specifically, not the entire navigator.credential api.
Passkeys are PublicKeyCredentials in the browser API and so will always be publicKey as the first argument which would just add a lot of unnecessary redundancy.

I am interested though do you have a strong reason for being closer to the navigator.credential api?

from react-native-passkeys.

getify avatar getify commented on June 27, 2024

I have a library that wraps around the webauthn API. I wanted that same library code (or with as few changes as possible) to run in react native.

Your library was initially very attractive for that purpose, because I viewed it as providing a sort of polyfill to RN for the underlying credentials API, which my library could then use.

I was dismayed to find this incompatibility in API, because it means I have to make more significant design changes to my library to force it to use wrappers around your API to patch over the incompatibility.

Your assertion that passkeys in the browser are always already having the "publicKey" property... does not match my experience. My library is constructing the object arguments to create() and get() manually itself, and is doing so in the form (with "publicKey") as expected by the API.

From that perspective, your library providing functions that look to be the same API as what the browser provides, but taking an incompatible form of arguments, is inconvenient and dismotivating to use in the way I conceived.

from react-native-passkeys.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.