Giter VIP home page Giter VIP logo

Comments (3)

mperham avatar mperham commented on July 22, 2024

That's a lot of issues in one comment. I mostly agree with your requests.

Dalli SHOULD only try to connect once per second. When a production system is calling memcached 100s of times per second, you cannot afford to wait 10 minutes for what might have been a temporary network hiccup. Once per second is, in my view, a reasonable trade off as long as Dalli is not filling your logs with errors.

Could you give me the exact output of what you are seeing?

from dalli.

gucki avatar gucki commented on July 22, 2024

The problem seems to be that dalli tries to get the version only once when dalli/ the servers are setup (Server#initialize). If a server is down, dalli somehow messes up so thar the whole app fails on each request.

I think it'd be better to move the code to detect the version from initialize to up!. This would also make dalli to redetect the version in case a server was shutdown and back up again (ex after an upgrade of the server).

I saw the code for the once per second (it's not very accurate because you simple check the second and dont take into account at which time you are within this second), but it should be easy to enhance this.

I'll also try to move the main connect code out of #connection and out it into #connect.

I hope to submit pull requests shortly :)

from dalli.

gucki avatar gucki commented on July 22, 2024

Fixed now! :)

from dalli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.