Comments (3)
Addressed by #2. Issue will be closed when the change makes it into the next npm package.
Thank you for the contribution.
from sveltekit-medusa-client.
Okay, so I figured out the issue. MedusaClient
expects headers to be passed on initialisation:
export default new MedusaClient(MEDUSA_BACKEND_URL, {
headers: {
'CF-Access-Client-Id': CLOUDFLARE_ACCESS_ID,
'CF-Access-Client-Secret': CLOUDFLARE_ACCESS_SECRET,
},
...
})
Which means that MeduseClient's query
function needs to check that headers exist before running the for loop:
async query(options: QueryOptions): Promise<Response | null> {
const { locals, path, method = 'GET', body = {} } = options;
let headers: any = {};
if (this.headers) {
for (const [key, value] of Object.entries(this.headers)) {
headers[key] = value;
}
}
...
}
from sveltekit-medusa-client.
Thank you for reporting this. Do you want to have a go at a PR? If not, I can probably do it tomorrow and post the new version.
I think the issue is in the way the interface is defined. It needs to allow for undefined. I am far from a Typescript expert as I only recently switched form js to ts. My approach would be to change the headers type to 'any' for now.
export interface ClientOptions {
retry?: number
timeout?: number
headers?: {}
persistentCart?: boolean
debug?: boolean
logger?: Logger
logFormat?: 'text' | 'json' | 'majel'
excludedPaths?: string[]
limitedPaths?: string[]
}
from sveltekit-medusa-client.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sveltekit-medusa-client.