Comments (4)
Hammer is not a traditional event emitter from javascript. It is only a normal object which follows observer pattern. Therefore, there is no need to destroy it because Javascript garbage collector will do it for us.
from vue-image-lightbox.
No, you still have to stop, destroy and set this variable to null to get garbage collector work.
You can check its documentation (http://hammerjs.github.io/api/) and an example from a react component (https://github.com/JedWatson/react-hammerjs/blob/master/src/Hammer.js#L122)
from vue-image-lightbox.
You are right in case of a dangling pointer where you attach an event to an outside component.
For example, if you attach event e
to component Father
which uses component Child
. If Child
is destroyed but Father
and e
are alive, then there will be a problem. Therefore, e
must be detached and destroyed also. However, if Child
and Father
are destroyed, there will be no dangling references and garbage collector can work well without killing e
.
You should notice that I attach 2 hammer
event to a DOM component which is inside the lightbox. After the lightbox is destroyed, both the hammer
object and this DOM component are destroyed also. Therefore it is unnecessary to detach and destroy the attached events.
In the React component vue-hammer
above, you can see that the hammer
object is a property of the component (this.hammer
). Hence, when the component is unmounted, he must kill the event because the DOM component is destroyed but hammer
is still alive. Things are different in the lightbox because hammer
is destroyed even before the DOM component is destroyed. I used to consider detach it but I found it unnecessary.
from vue-image-lightbox.
Thank you, I get your point! But I will do more test to make sure everything works properly!
from vue-image-lightbox.
Related Issues (20)
- Multi video playing. HOT 1
- Possible to set target of lightbox to be the parent of an iframe? HOT 3
- Use lightbox with Nuxt.js HOT 2
- Swipe actions don't initialize when media is initially empty HOT 1
- Clicking on the image causes the entire parent element to turn into a black screen. HOT 3
- How to custom current image display in light-box by using slot? HOT 3
- Why remove slot footer when "media.length = 1"? HOT 4
- Base64 image HOT 1
- VueJS3 support
- "Cannot read property 'type' of undefined" error when media array is empty HOT 11
- Missing type definition for TypeScript HOT 2
- onClosed not working
- SVG not load according to insinsic size
- Thumbnail not load
- Thumbnails should scroll horizontally
- Multiple videos are not re-rendering the video component when switching between them HOT 1
- Add pdf support HOT 2
- showImage flashes first image before showing desired image HOT 3
- how to close the light box when click outside of the image?
- Multi Video play problem HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vue-image-lightbox.