Comments (4)
I don't know how I can help here.
The pf4j-spring
is very tiny and easy to hack. All the business is available in two classes: SpringExtensionFactory and ExtensionsInjector. The extension is injected as bean in SpringExtensionFactory#create.
I am not familiar with @primary annotation but it seems that the behavior of this annotation can be easy emulated via code:
Greeting getGreeting() {
// pseudo code
if (greetings.isEmpty) {
return null;
} else {
return greetings.get(0); // first
}
}
If you want something automatically (not the first greeting extension), I think that you can add @primary on an extension class and use this information in ExtensionsInjector
. Please take a look on #6 to have an idea.
from pf4j-spring.
Maybe this link helps.
from pf4j-spring.
In GreetingsController you say:
This works with just the system extension, but fails with more than one even when one is marked
@Primary
Yes, this behavior is normal (with current implementation) because PF4J creates the extensions instances, and not Spring. In this context, any Spring's annotation that exists on the extension class (like Scope
, Primary, ...
) must be treated/interpreted by PF4J (pf4j-spring) when an extension's instance is created. After the extension's instance was created, the object is injected in Spring as bean.
If the extension's instance was created by Spring, then Spring would take care of all these aspects (annotations). So, the perfect/ideal solution is to let Spring to create these instances of extensions but I don't know how we can do this.
from pf4j-spring.
Maybe an idea is to use the meta annotation concept from Spring (for more details see this).
On the master branch of PF4J there is already support for the extensively decorated annotation(pf4j/pf4j#347). So, right now, we can write something like:
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
@Documented
@Extension
@Component
public @interface SpringExtension {
}
where @Extension
defines an extension in PF4J and @Component
defines a component in Spring.
What else we should do is implement an ExtensionFactory
(see SpringExtensionFactory) that extracts the extension instance from Spring on create(Class<T> extensionClass)
.
It's just an idea. It's not validated in practice.
from pf4j-spring.
Related Issues (20)
- update dependencies to newest spring 5.+ versions HOT 1
- Concrete bean could not be received from the application context HOT 1
- SpringPlugin start/stop/start results in Exception HOT 2
- Loading plugin on-runtime : Ambiguous hander methods mapped & ConcurrentModificationException when unregistering routes
- I use it SpringPluginManager, It seems to be a single case. HOT 4
- How to update the βList<Greeting>β while some plugins unloaded and deleted? HOT 4
- How to add integration tests for the plugin?
- self contained example HOT 1
- Jpa in plug-in not working HOT 1
- Hi author, Can I send a pull request to PF4J-Spring to support the Spring parent-child context οΌ
- Injecting beans from plugin in application doesn't work HOT 2
- run exception on pf4j-spring demo
- pf4j plugin needs to refresh and detect changes automatically with spring HOT 6
- How to get this repo versions release notes? HOT 2
- Problems with Using Pf4j-Spring HOT 1
- The real implementation cannot be accessed through the api interface. HOT 2
- When 'spring-boot-devtools' is introduced in the project, the extensions are not available. HOT 2
- How do you extend with kafka HOT 1
- Retrieve Resource from Inside Plugin HOT 1
- When will plan support Spring6.x ? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pf4j-spring.