Giter VIP home page Giter VIP logo

Comments (21)

pfefferle avatar pfefferle commented on June 19, 2024

I think it is a semantic-linkback thing... I will have an eye on it, but it is not that easy to reproduce ;)

from wordpress-webmention.

snarfed avatar snarfed commented on June 19, 2024

thanks for paying attention to it. i'll definitely help.

from wordpress-webmention.

pfefferle avatar pfefferle commented on June 19, 2024

Can it depend on closed comments?

from wordpress-webmention.

snarfed avatar snarfed commented on June 19, 2024

good guess...but no, i turned that off. none of my posts are ever closed for comments.

there are actually lots of comments on that post right now, they just don't show up because of wordpress-webmention/issues#13. i'll go delete the cache file to fix that.

from wordpress-webmention.

snarfed avatar snarfed commented on June 19, 2024

done: http://snarfed.org/2014-01-28_language-duct-tape

from wordpress-webmention.

pfefferle avatar pfefferle commented on June 19, 2024

That means that I can close this one?

from wordpress-webmention.

snarfed avatar snarfed commented on June 19, 2024

sorry, no. :/ the two webmentions i mentioned above still never showed up. i just cleared the cache so you could see the others.

from wordpress-webmention.

pfefferle avatar pfefferle commented on June 19, 2024

Ok, but that means that it is definitely a semantic-linkback problem... because the webmention plugin sends the correct headers...

from wordpress-webmention.

snarfed avatar snarfed commented on June 19, 2024

i think this was wordpress's "comment flood" detection, which returns 403 errors after any IP starts creating too many comments too quickly. i've installed the Disable Check Comment Flood plugin to prevent this. sorry for the false alarm!

from wordpress-webmention.

snarfed avatar snarfed commented on June 19, 2024

...actually, that couldn't be it, since these requests both returned 200. hrm. never mind!

from wordpress-webmention.

pfefferle avatar pfefferle commented on June 19, 2024

The flood control thing returns a HTML page and I think this page uses a normal 200 header... This is a bit odd... Can you send me the link to the flood control plugin, perhaps I could include something similar to the plugin...

from wordpress-webmention.

mapkyca avatar mapkyca commented on June 19, 2024

May be relating to this, maybe not, I'm getting a bunch of comments hitting the endpoint but end up silently being marked as spam.

Not sure if there's anything we can/should do about that (you can mark comments as approved on creation, but that might cause other issues). Anyway, y'know, just an FYI.

from wordpress-webmention.

snarfed avatar snarfed commented on June 19, 2024

hmm, you might be right about a normal 200 page vs 403. i may have misremembered. anyway, here's the plugin: http://wordpress.org/plugins/disable-check-comment-flood/

it's trivial, it's literally just this:

remove_filter('check_comment_flood', 'check_comment_flood_db');

from wordpress-webmention.

pfefferle avatar pfefferle commented on June 19, 2024

@mapkyca might be... the webmentions will be also checked by spam filters like askimet, like any other comment... I added all bird.gy links to the wordpress whitelist for example...

@snarfed I will try to disable it before i add the comment and reenable it afterwards... I hope this will work :)

from wordpress-webmention.

mapkyca avatar mapkyca commented on June 19, 2024

Further to this... bit of a head scratcher....

Actually had a stuck webmention, pulled the log from brid.gy and ran the request again using CURL. Webmention data was successfully pulled, comment looked ok, comment was saved - wp_new_comment returned an ID. When I looked in the database this comment did not exist.

So, it looks like something is coming along and removing the comment after it is created, and/or, there's a bug in wordpress whereby it'll return an ID even though there was a problem writing the comment. Not sure, haven't traced it back.

This was done with the Akismet plugin switched off, so it shouldn't be that.

Also tried wp_insert_comment, which supposedly bypasses comment filters, but no joy.

from wordpress-webmention.

mapkyca avatar mapkyca commented on June 19, 2024

Bingo: It's the do_action('webmention_post', $comment_ID) line.

Comment that out and the webmention is posting... not sure why this causes the comment to delete itself, and only sometimes, but hey....

from wordpress-webmention.

pfefferle avatar pfefferle commented on June 19, 2024

Then it seems to be the semantic-linkback-plugin... I will have a look at it and will change some parts... In some cases the semantic-linkback-plugin has to delete the webmention... long story :)

from wordpress-webmention.

pfefferle avatar pfefferle commented on June 19, 2024

I think this is also because of the comment-flood mechanism. The webmention is saved... the semantic-linkback plugin deletes it, to generate a more semantic one, but can't save it because of the flood mechanism.

@mapkyca Thanks for debugging it!

@snarfed I think I will disable the comment-flood mechanism at least for the webmention (and the semantic linkback) plugin.

from wordpress-webmention.

mapkyca avatar mapkyca commented on June 19, 2024

No problem :)

from wordpress-webmention.

snarfed avatar snarfed commented on June 19, 2024

agreed, nice debugging guys! makes sense to me, thanks for doing this.

from wordpress-webmention.

pfefferle avatar pfefferle commented on June 19, 2024

should be fixed now

from wordpress-webmention.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.