Comments (6)
The idea is good, but I am not sure if this should be part of the core plugin, because it is very brid.gy specific. The spec doesn't specify the response at all, so I think it would be cool to code a bird.gy plugin that hooks into the "send_webmention" action (if added a filter today bf62f8f#diff-a206f8eddc4eec457824d08af6ecd005R319)
what do you think @snarfed?
from wordpress-webmention.
This was the debate I was trying to figure out. Should the response be
loaded by the webmentions plugin and then retrieved by a Bridgy plugin or
aware theme or both be in a Bridgy plugin. That's why I filed it as an
issue. Sending data in the response is Bridgy specific, but doesn't have to
be.
On May 5, 2014 2:40 PM, "Matthias Pfefferle" [email protected]
wrote:
The idea is good, but I am not sure if this should be part of the core
plugin, because it is very brid.gy specific. The spec doesn't specify the
response at all, so I think it would be cool to code a bird.gy plugin
that hooks into the "send_webmention" action (if added a filter today
bf62f8f#diff-a206f8eddc4eec457824d08af6ecd005R319bf62f8f#diff-a206f8eddc4eec457824d08af6ecd005R319
)what do you think @snarfed https://github.com/snarfed?
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-42222007
.
from wordpress-webmention.
actually, the webmention spec strongly encourages a response body: The response body SHOULD include a URL that can be used to monitor the status of the request. lots of other existing implementations send one, including this plugin, p3k, webmention.io, and i think idno, so this probably isn't specific to bridgy.
from wordpress-webmention.
Either way, the filter addition allows for that and is probably better than
dumping it to mets as it allows for custom handling.
On May 5, 2014 3:09 PM, "Ryan Barrett" [email protected] wrote:
actually, the webmention spec strongly encourages a response bodyhttps://github.com/converspace/webmention/blob/master/README.md#sender-notifies-receiver:
The response body SHOULD include a URL that can be used to monitor the
status of the request. lots of other existing implementations send one,
including this plugin, p3k, webmention.io, and i think idno, so this
probably isn't specific to bridgy.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-42225626
.
from wordpress-webmention.
👍 filter (or hook) makes sense to me too.
from wordpress-webmention.
Thanks for pointing me to the response body part. I will also change the response of the plugin to return a more useful information, like the url of the comment.
from wordpress-webmention.
Related Issues (20)
- Minor refactor of webmention_extract_urls in functions.php
- Sanity check send_webmentions() in class-sender.php HOT 2
- Add Bulk Action to Migrate Avatars to Local Storage if You Have Store Enabled
- Add Ability to Change Avatar URL Manually or Upload to Store Manually
- PHP Fatal error: Uncaught TypeError: DOMXPath
- Getting "Der Ziel-Link konnte nicht gefunden werden" HOT 8
- Add Filter to Allow Changing the Ping Me Button Text
- Facepile Links to Profile over URL HOT 3
- PHP Fatal error: Uncaught TypeError: Cannot access offset of type string HOT 1
- PHP Fatal error: Uncaught TypeError: Cannot access offset of type string (line 782) HOT 1
- Also use comment URL fragment for reply nesting? HOT 1
- Null reference to comment_parent HOT 2
- Not sending webmentions for deletes (ie when moving a post to trash)
- Rare edge case where the answer was sort of hidden.
- Fatal error due to broken comment query callback HOT 1
- PHP Fatal error: Uncaught Error: Attempt to modify property "query_vars" on string HOT 5
- Webmentions not showing up as comments in 2024 theme on latest version HOT 1
- Race condition causes duplicate comments for same webmention source + target HOT 1
- Shorten Replies if Too Long HOT 1
- Reply from an Article
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wordpress-webmention.