Giter VIP home page Giter VIP logo

Comments (9)

Noaber avatar Noaber commented on June 14, 2024 1

Hello @pH-7 ,

It was great!
Will check on monday, back @ work then :)

from eu-vat-validator.

pH-7 avatar pH-7 commented on June 14, 2024

Thanks for the suggestion @Noaber!

Do you mind to create a PR doing that? And run the phpunit test (update the test if necessary) once done

Probably, it will be better to create a new method or rename the existing method to something different like cleanAddress()

Thanks

from eu-vat-validator.

pH-7 avatar pH-7 commented on June 14, 2024

BTW @Noaber What's the VAT number you used where you got commas?, so I can reproduce it (because in my case, I don't get commas).

from eu-vat-validator.

Noaber avatar Noaber commented on June 14, 2024

I will check it after my vacation 😉

from eu-vat-validator.

pH-7 avatar pH-7 commented on June 14, 2024

Perfect @Noaber! I will keep it open then.
Enjoy your vacation! 🌴😃

from eu-vat-validator.

pH-7 avatar pH-7 commented on June 14, 2024

Hi again @Noaber
How was your vacation? Did you have the chance to see with what VAT number you have seen the commas in the address?

from eu-vat-validator.

pH-7 avatar pH-7 commented on June 14, 2024

👍 Beautiful! Thx!

from eu-vat-validator.

Noaber avatar Noaber commented on June 14, 2024

Took some more time then expected :) but I am trying with number NL004206034B01

$vat_validator = new Validator(new Europa, $vat_nr, 'NL');

This gives me , NIJVERHEIDSSTRAAT 00041, 7461AD RIJSSEN,

from eu-vat-validator.

pH-7 avatar pH-7 commented on June 14, 2024

Thanks @Noaber!
I can see it doesn't normally have commas, as officially shown at http://ec.europa.eu/taxation_customs/vies/
I will publish a patch for it.

from eu-vat-validator.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.