Giter VIP home page Giter VIP logo

Comments (5)

bagustris avatar bagustris commented on July 24, 2024

This is not replacing the original purpose of the code I think. Instead of using multiply, you should using Concatenate or Add.

from keras-attention.

YanShulinjj avatar YanShulinjj commented on July 24, 2024

what version of keras should replace these points?

from keras-attention.

JunkyByte avatar JunkyByte commented on July 24, 2024

This is not replacing the original purpose of the code I think. Instead of using multiply, you should using Concatenate or Add.

If you look at the mode params of the merge call it is mul which makes multiplication.
So the answer from @korolaab is correct (also if you look at the paper / implementations it is pretty clear that there's a multiplication there as you combine attention and input, attention is a prob. distribution (as is the output of a softmax activation).
So addition or concatenation would not make much sense.

from keras-attention.

shangbecky avatar shangbecky commented on July 24, 2024

I agree with @korolaab and @JunkyByte

from keras-attention.

philipperemy avatar philipperemy commented on July 24, 2024

Code has been updated. Thanks guys :)

from keras-attention.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.