Giter VIP home page Giter VIP logo

Comments (10)

sksamuel avatar sksamuel commented on July 24, 2024

Should just be a case of adding that parameter to the definition.

from elastic4s.

sksamuel avatar sksamuel commented on July 24, 2024

Ok usually I'm in favour of keeping the DSL to match the json values. So in this case something like dynamic strict or dynamicStrict true ? Although I actually think your syntax makes more sense than the actual elasticsearch one.

from elastic4s.

tovbinm avatar tovbinm commented on July 24, 2024

dynamicStrict SGTM

from elastic4s.

sksamuel avatar sksamuel commented on July 24, 2024

I've added a commit to allow this

create index "twitter" mappings(
  "tweet" as (
      //...
   ) dynamic Strict
)

But I can change it.

from elastic4s.

sksamuel avatar sksamuel commented on July 24, 2024

Which is the same as

create index "twitter" mappings(
  "tweet" as (
      //...
   ).dynamic(Strict)
)

If you like parenthesis

from elastic4s.

tovbinm avatar tovbinm commented on July 24, 2024

Great. Thanks!!

from elastic4s.

sksamuel avatar sksamuel commented on July 24, 2024

It's on master. Do you need a release to central ?

from elastic4s.

tovbinm avatar tovbinm commented on July 24, 2024

Sure.

from elastic4s.

benburton avatar benburton commented on July 24, 2024

Unfortunately, using Strict means that indexing will fail on documents with dynamic values:

"The dynamic parameter can also be set to strict, meaning that not only will new fields not be introduced into the mapping, but also that parsing (indexing) docs with such new fields will fail."

I have a scenario where I want to not index unmapped values, but not have them fail altogether. I think that setting dynamic to false achieves this goal (from the documentation, it appears that it works that way for subdocuments).

from elastic4s.

tovbinm avatar tovbinm commented on July 24, 2024

Hmm. It's worth checking.

from elastic4s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.