Non-blocking Future about elastic4s HOT 8 CLOSED

I guess the idea is you can pass in your own execution context if you think it might become a bottleneck.

If we move to using a Promise that we complete using an action listener, then the bottleneck moves to the underlying elasticsearch client executor, right? If so, what's the advantage?

I'm not against the idea of doing it this way, I just need to better understand the advantage.

from elastic4s.

ES java client manages it's own thread pool. If we make a blocking call in a single client-wide ExecutionContext, the intermediate thread will be blocked and the ES thread pool won't be fully utilized.

from elastic4s.

I see that we are thinking about slightly different cases.
I am using the case that people will use the client as a non data node (using transport client for example), in which case the client has its own thread pool that is no different to the a thread pool you can specify to the e4s client. I think you're using the case where your client is also a data node, in which case using ES's own thread pool might be better.
Perhaps we can solve this by adding in the callback methods you suggest, but keeping the "internal thread pool" ones as well? What do you think ?

from elastic4s.

In usual, when you send an async request via a transport client, it registers a callback on it's internal thread pool and the pool will notify when it's done. Additional requests will be handled in the same manner.

However, by blocking request inside a shared execution context, additional ones won't be sent until the previous one is done and the thread pool will hold only one request at once like this:

from elastic4s.

There should be Elastic4s client between 'User' and 'ExecutionContext'..

from elastic4s.

Yes I see what you mean. I'll follow up tonight with some conversion work, or you can start on a branch if you want.

from elastic4s.

take a look over what I've done, feedback very much welcome.

from elastic4s.

Thanks :) I'll send a following PR in a few days.

from elastic4s.