:not pseudo-class attribute selector breaks Floki.find/2 with comma-separated selectors about floki HOT 3 CLOSED

Hi @philss! Thanks for the quick and detailed response.

After a quick look into the linked code, my conclusion for now is that "I also can handle this later this week" is indeed what I prefer 😄. I'm afraid it'll take me longer than that before I have the time to get this fixed.

This being said, I think I've pinpointed the exact test assertion that should be changed:

This test is asserting the return value for Parser.parse("a.foo:not([style*=crazy], .bar)") and currently (wrongly!) expects the value to be a list that only contains a %Selector{} for type: "a". In reality, there should also be a second selector matching .bar.

I'm not entirely sure what this .bar %Selector{} should contain, but I hope this saves you some research time.

Thanks again for getting back so quickly, greatly appreciated!

from floki.

This test is asserting the return value for Parser.parse("a.foo:not([style*=crazy], .bar)") and currently (wrongly!) expects the value to be a list that only contains a %Selector{} for type: "a". In reality, there should also be a second selector matching .bar.

In this case, the second selector is going to be inside the "not" pseudo-class - we should have two selectors inside this pseudo-class, and one outside.

@florish thanks for the tips and for opening the issue! 💜

I should release a new version soon.

from floki.

Hey @florish 👋
Thanks for open the issue!

Yeah, this is really strange. For some reason the parsing of the :not pseudo-class is also including the hr.

You can observe that by inspecting the value of pseudo_class here:

I think the problem may be at the selector parser, around the do_parse_pseudo_not/2 function:

There are tests for this module in here: https://github.com/philss/floki/blob/57c07e00d0983928546de0853d007e16827fbe8d/test/floki/selector/parser_test.exs

Please let me know if you need more guidance. (I also can handle this later this week if you prefer).

from floki.