Comments (5)
I've just encountered this too. Changing any of the logging settings (obviously) has no effect, as even though the lines are correct they're still commented out.
from chef-postgresql.
The postgresql.conf
file as-is is the default that ships with the package. Simply uncommenting all of the options results in the server unable to load.
My plan is to eventually support explicit templating as I do in phlipper/chef-percona, but I have not had a chance to implement that yet.
Pull requests to improve this support would gladly be welcomed.
from chef-postgresql.
@smith, @jagregory, this issue has been addressed via 394bbc1.
from chef-postgresql.
I ran into this just now... I'm changing the WAL settings, but they are commented out.
I understand if I switch to 'custom' configs, i.e, ['postgresql']['conf']['archive_mode'] etc, that I'll get what I want.
Ok, that's fine--but what I'm confused about is offering up the 'standard' template mechanism in the docs. It seems to me the standard config feature is broken as long as the commenting out. Is there a way to practically use it?
A question--if you could tell that that the user specified something other than the default value in your template, would you then not feel comfortable in commenting out that specific config?
Something like:
<%= wal_level_specified? ? '#' : "" %>wal_level = <%= node["postgresql"]["wal_level"] %> # minimal, archive, or hot_standby
from chef-postgresql.
I agree with @sethcall on this one. Because if someone uses the node[:postgresql][:conf][ ... ]
options, then they need to specify every option and can't rely on the postgresql reasonable defaults. The current implementation renders most of the node[:postgresql][ ... ]
conf related attributes useless and the node[:postgresql][conf][ ... ]
attributes impractical.
One strategy is to have the default node attributes set to nil
if their corresponding configuration options that are commented out in the stock postgresql.conf
; in the template, have each of those lines go something like:
<%= node['wal_level'].nil? ? '# wal_level = minimal' : "wal_level = #{node[:postgresql][:wal_level]}" %> # minimal, archive, or hot_standby
While there is some verbosity, I think this is a nice compromise to having as much of the stock postgresql.conf
be preserved as possible. This would also make the documentation clearer and less misleading.
Thoughts? I'd be happy to work on this if this is the direction you'd like to go @phlipper.
from chef-postgresql.
Related Issues (20)
- Submitting to Chef community? HOT 5
- pg_hba error with 9.4 HOT 2
- NoMethodError: undefined method `sensitive' HOT 2
- Berkshelf install? HOT 2
- createlang cannot find plperl HOT 3
- gem install pg error
- Conditional enablement of service HOT 1
- prevent cluster init / create_main_cluster? HOT 3
- Fix filename of preferences.d and integration tests HOT 1
- Getting RuntimeErrors when attempting to locate files in `templates/default` directory HOT 3
- cannot load such file -- pg when creating a database
- Backports error on Debian 8 (jessie) HOT 1
- Minified recipe HOT 4
- Database server build not working on Ubuntu Server 15.04 HOT 2
- Replication support HOT 1
- Any plans to make this support RedHat?
- Spec failure dependent on execution order HOT 1
- Postgres 9.5 compatibility HOT 3
- Cleanup PR
- error with apt HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chef-postgresql.