Giter VIP home page Giter VIP logo

Comments (8)

Phoenix616 avatar Phoenix616 commented on July 3, 2024

Can you try setting it like debug: "false"? Bungee's yaml configuration adapter is a bit more finicky than Bukkit's even though I already try to do a detection that catches all cases.

from resourcepacksplugins.

mibby avatar mibby commented on July 3, 2024

Putting it in quotes does seem to work!

[BungeeResourcepacks]: Debug level: OFF

It could also explain why #16 doesn't work. So any setting changes not in quotes just sticks to the default.

You don't seem to have a catch case for false without quotes?

from resourcepacksplugins.

Phoenix616 avatar Phoenix616 commented on July 3, 2024

Well it seems that the YAML library or configuration API changed behaviour again... previously getString threw a ClassCastException when you tried to get a boolean with it, seems like it now just returns the default value in such a case instead of the value as a string :/

The usepack-is-temporary option only uses getBoolean though so that should work correctly without quotes and I doubt it's the same issue. (that would make the getBoolean method completely useless and I doubt nobody noticed that) Are you still using Waterfall? Because I remember them using a different version of the YAML library than Bungee.

from resourcepacksplugins.

mibby avatar mibby commented on July 3, 2024

I am using Waterfall, yes.

from resourcepacksplugins.

mibby avatar mibby commented on July 3, 2024

BungeeResourcePack dev 219.

@Phoenix616 This is still broken.

Without quotes.

debug: false

It outputs at start-up that debug level is OFF.

[06:33:36] [main/INFO] [BungeeResourcepacks]: BungeeCord 1.9.4+ (393) detected!
[06:33:36] [main/INFO] [BungeeResourcepacks]: Registered ResourcePackSendPacket for 1.8
[06:33:36] [main/INFO] [BungeeResourcepacks]: Registered ResourcePackSendPacket for 1.9
[06:33:36] [main/INFO] [BungeeResourcepacks]: Registered ResourcePackSendPacket for 1.12
[06:33:36] [main/INFO] [BungeeResourcepacks]: Registered ResourcePackSendPacket for 1.12.1
[06:33:36] [main/INFO] [BungeeResourcepacks]: Registered ResourcePackSendPacket for 1.12.2
[06:33:36] [main/INFO] [BungeeResourcepacks]: Registered ResourcePackSendPacket for 1.13
[06:33:36] [main/INFO] [BungeeResourcepacks]: Detected ViaVersion 1.4.2-1.13.1-pre1
[06:33:36] [main/INFO] [BungeeResourcepacks]: Loading config!
[06:33:36] [main/INFO] [BungeeResourcepacks]: Debug level: OFF
[06:33:36] [main/INFO] [BungeeResourcepacks]: Loading packs:
[06:33:36] [main/INFO] [BungeeResourcepacks]: serverpackv4 - http://censored/serverpack/serverpackv4.zip - 83e0831c5673e9c7bc59cf49f14c49b63c9b2919
[06:33:36] [main/INFO] [BungeeResourcepacks]: serverpackv3 - http://censored/serverpack/serverpack.zip - c9170f103d96b35b6819db39a537ccdab8b920ab
[06:33:36] [main/INFO] [BungeeResourcepacks]: serverpackv2 - http://censored/serverpack/serverpackv2.zip - 2f08d294bcb04fe2ad7502aafd3a01390ad3d31e
[06:33:36] [main/INFO] [BungeeResourcepacks]: serverpackv1 - http://censored/serverpack/serverpackv1.zip - fd02424ccdeb8d12f56957dffc0cf489a714c0d8
[06:33:36] [main/INFO] [BungeeResourcepacks]: Empty pack - http://cdn.moep.tv/files/Empty.zip - c05faed4680570a6159823e13fbae2ae830166ab
[06:33:36] [main/INFO] [BungeeResourcepacks]: Loading global assignment...
[06:33:36] [main/OFF] [BungeeResourcepacks]: Pack: serverpackv4
[06:33:36] [main/OFF] [BungeeResourcepacks]: Secondary packs:
[06:33:36] [main/OFF] [BungeeResourcepacks]: - serverpackv3
[06:33:36] [main/OFF] [BungeeResourcepacks]: - serverpackv2
[06:33:36] [main/OFF] [BungeeResourcepacks]: - serverpackv1
[06:33:36] [main/OFF] [BungeeResourcepacks]: Send delay: 20
[06:33:36] [main/INFO] [BungeeResourcepacks]: Loaded global assignment PackAssignment{name=global, pack=serverpackv4, secondaries=[serverpackv3, serverpackv2, serverpackv1], sendDelay=20}
[06:33:36] [main/INFO] [BungeeResourcepacks]: Loading server assignments...
[06:33:36] [BungeeResourcepacks Pool Thread #0/INFO] [BungeeResourcepacks]: Generating hashes...
[06:33:36] [BungeeResourcepacks Pool Thread #0/INFO] [BungeeResourcepacks]: Downloading serverpackv4...
[06:33:36] [main/OFF] [BungeeResourcepacks]: 
[06:33:36] [main/OFF] [BungeeResourcepacks]:   If you enjoy my BungeeResourcepacks plugin then you might also be
[06:33:36] [main/OFF] [BungeeResourcepacks]:   interested in the more advanced ForceResourcepacks version!
[06:33:36] [main/OFF] [BungeeResourcepacks]: 
[06:33:36] [main/OFF] [BungeeResourcepacks]:   Besides getting additional features like WorldGuard support and
[06:33:36] [main/OFF] [BungeeResourcepacks]:   the ability to force a player to accept the resources pack you
[06:33:36] [main/OFF] [BungeeResourcepacks]:   will also support the continued development of this plugin!
[06:33:36] [main/OFF] [BungeeResourcepacks]: 
[06:33:36] [main/OFF] [BungeeResourcepacks]:   Check it out here on spigotmc.org: https://s.moep.tv/frp
[06:33:36] [main/OFF] [BungeeResourcepacks]: 
[06:33:36] [main/OFF] [BungeeResourcepacks]:   - Phoenix616
[06:33:36] [main/OFF] [BungeeResourcepacks]: 
[06:33:36] [main/INFO]: Enabled plugin BungeeResourcepacks version 1.6.19-SNAPSHOT (build #219) by Phoenix616

But it still outputs in Bungee console / logs with [BungeeResourcepacks Pool Thread #6/OFF].

	Line 81: [06:34:47] [BungeeResourcepacks Pool Thread #2/OFF] [BungeeResourcepacks]: player matched global assignment
	Line 82: [06:34:47] [BungeeResourcepacks Pool Thread #2/OFF] [BungeeResourcepacks]: Send pack serverpackv3 (http://censored/serverpack/serverpack.zip) to player
	Line 86: [06:34:56] [BungeeResourcepacks Pool Thread #2/OFF] [BungeeResourcepacks]: player matched global assignment
	Line 87: [06:34:56] [BungeeResourcepacks Pool Thread #2/OFF] [BungeeResourcepacks]: Send pack serverpackv4 (http://censored/serverpack/serverpackv4.zip) to player
	Line 90: [06:38:59] [BungeeResourcepacks Pool Thread #3/OFF] [BungeeResourcepacks]: player matched global assignment
	Line 91: [06:38:59] [BungeeResourcepacks Pool Thread #3/OFF] [BungeeResourcepacks]: Send pack serverpackv3 (http://censored/serverpack/serverpack.zip) to player
	Line 94: [06:43:34] [BungeeResourcepacks Pool Thread #4/OFF] [BungeeResourcepacks]: player matched global assignment
	Line 95: [06:43:34] [BungeeResourcepacks Pool Thread #4/OFF] [BungeeResourcepacks]: Send pack serverpackv1 (http://censored/serverpack/serverpackv1.zip) to player
	Line 101: [06:45:11] [BungeeResourcepacks Pool Thread #5/OFF] [BungeeResourcepacks]: player matched global assignment
	Line 102: [06:45:11] [BungeeResourcepacks Pool Thread #5/OFF] [BungeeResourcepacks]: Send pack serverpackv3 (http://censored/serverpack/serverpack.zip) to player
	Line 105: [06:45:31] [BungeeResourcepacks Pool Thread #5/OFF] [BungeeResourcepacks]: player matched global assignment
	Line 106: [06:45:31] [BungeeResourcepacks Pool Thread #5/OFF] [BungeeResourcepacks]: Send pack serverpackv3 (http://censored/serverpack/serverpack.zip) to player
	Line 109: [06:49:05] [BungeeResourcepacks Pool Thread #6/OFF] [BungeeResourcepacks]: player matched global assignment
	Line 110: [06:49:05] [BungeeResourcepacks Pool Thread #6/OFF] [BungeeResourcepacks]: Send pack serverpackv3 (http://censored/serverpack/serverpack.zip) to player

from resourcepacksplugins.

Phoenix616 avatar Phoenix616 commented on July 3, 2024

It is up to your logger/terminal how it handles the OFF logging level.

from resourcepacksplugins.

mibby avatar mibby commented on July 3, 2024

So it would be a Waterfall issue?

@electronicboy

from resourcepacksplugins.

Phoenix616 avatar Phoenix616 commented on July 3, 2024

Apparently this is my fault. I thought logging with OFF meant that it isn't supposed to show anything but apparently they thought only about using that to completely turning the logger off and not for using it in Logger#log... probably gonna move to FINEST

from resourcepacksplugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.