Comments (6)
No, that did not fix it. I added a test to describe the behaviour I am after. Correct me if I am wrong:
- Look in the changes,
- if nothing is there, look in the params,
- if nothing is there, look in the data,
- if nothing is there, return the default value or nil.
I'll see if I can make the changes.
from phoenix_ecto.
I can't fix it in this repo. This behaviour needs a change in phoenixframework/phoenix_html.
The precedence now is: params -> default -> changes -> data.
This feels wrong, especially that the default value is taken before the changes or actual data.
I think the precedence should be: changes -> params -> data -> default.
from phoenix_ecto.
@ThijsWouters can you please check Ecto master?
You are correct except by the default which should have higher preference than the data because the default often uses a value computed on top of the data.
from phoenix_ecto.
@josevalim Taking the default over the data does not make sense to me.
Let's say we have a transaction with a date. We want a default date of today.
So you say that when we start to edit the transaction, the date field is not filled with the previously chosen date, but with the current date?
from phoenix_ecto.
The default is used for cases where you want to use a value that was computed on top of the data value, hence you want it to have higher precedence:
input_value(form, :name, String.upcase(data.name))
If you really want a value if nothing else was set then you can do this:
input_value(form, :name) || "fallback"
Maybe it is a matter of giving it a better name than default, such as "computed".
Changing it would also be backwards incompatible, so finding a better way to describe is the best way to go.
Did the rest work as expected on master?
from phoenix_ecto.
It does work as expected on master, thanks.
default
is indeed a confusing name for something like this.
from phoenix_ecto.
Related Issues (20)
- Advanced select HOT 1
- Do not require `as:` option HOT 2
- inputs_for :append/:prepend options don't add inputs if there is an error in the changset HOT 3
- (chore): upgrade to latest ecto version HOT 2
- Error on inputs_for when using with MFA option on cast_assoc HOT 2
- Missed `InvalidChangesetError` errors on `apply_action!/2` because they got transformed into `:debug` messages HOT 2
- Should Ecto.ChangeError be handled by plug.ex? HOT 4
- Phoenix.Ecto.CheckRepoStatus throws error in CLI if database "postgres" is not used HOT 9
- Navigation bar link showing un-decoded HTML entities title. HOT 1
- Problem with nested input with version 4.2.1 HOT 7
- String keys in form input helpers HOT 3
- Phoenix.Ecto.CheckRepoStatus.init/1 is undefined HOT 6
- Trying to upgrade phoenix and Liveview to latest versions, dependency error with phoenix_html HOT 3
- Distinguish queries made by phoenix_ecto HOT 9
- Ecto.Adapters.SQL.Sandbox times out in CI (GH Actions/Semaphore) HOT 3
- Phoenix.Ecto.SQL.Sandbox support for multi repos? HOT 2
- Tasks inside LiveView do not run in sandbox HOT 25
- `to_form` does not copy the `:action` field HOT 2
- New release? HOT 2
- Update version dependencies?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phoenix_ecto.