Giter VIP home page Giter VIP logo

Comments (6)

jiangzhenjerry avatar jiangzhenjerry commented on May 18, 2024 5

Hi! Sorry for bumping a closed ticket. I do enjoy the "Set as album cover photo" function, so thanks for implementing it. On the other hand, maybe one day this feature could be extended a bit? For example, for the following folder structure:

Folder A
├── Folder B
│   ├── 1.jpg
│   └── 2.jpg
└── Folder C
    ├── 3.jpg
    └── 4.jpg

We can now easily change the cover photos of Folder B and Folder C, but not that of Folder A because Folder A doesn't have any photos directly under it.

Furthermore, if I change the cover photo of Folder B to 2.jpg (from 1.jpg by default), Folder A would still use 1.jpg (first photo in the first subfolder) as the cover photo. It would be nice if Folder A at least follows my choice of cover photo for Folder B.

from photoview.

viktorstrate avatar viktorstrate commented on May 18, 2024

Hi @FelixUster

I think this is would be a nice feature.
It could be implemented in a similar way as how Google Photos does it. Clicking a button labeled "Use as album cover".

If you have very little experience with Javascript and Go, then I think it would be quite ambitious to implement this.
But if you want to give it a shot nevertheless, here are the basic steps:

  • Add a database migration where a new column is added for a potential cover image, referencing the media_id of the selected cover image.
  • Add and implement a graphql mutation to change the cover of an album.
  • Update the album thumbnail resolver to use the selected album cover if set, otherwise use the current implementation to dynamically select the first one.
  • Integrate the graphql mutation into the web interface.

from photoview.

viktorstrate avatar viktorstrate commented on May 18, 2024

Implemented in #526

from photoview.

EgonHeuson avatar EgonHeuson commented on May 18, 2024

This would be an amazing feature!! ❤️ But Photoview is already a very nice job! Thanks!!

from photoview.

hcooper avatar hcooper commented on May 18, 2024

+1 controlling the album cover of a parent album would be great.

from photoview.

Lingxi-Li avatar Lingxi-Li commented on May 18, 2024

+1 for the feature to set cover page of albums that contain no photo but only sub-albums.

from photoview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.