Comments (6)
This is how I reason about this. Im not sure it is "the correct answer" but it is something I currently believe in.
Since we are using Loco, we should not care how translation are stored on our local disk. In fact, we should not have translation files in git. Since XML is far better than any other format for all aspects (but readability for humans), it should always be used. Especially since you never read the translation files anymore. You read them in Loco, sf web profiler or the web ui.
I've know php-translation has a quite rough "getting started, import your translation" procedure. It is also fairly undocumented. You should basically import what you got to Loco and then throw away your translation files. =)
An easy fix for that would be to add an option where user can specify desired format.
Yes, agree. Though, I argue above why I think this is not needed. However there is no reason why we should not have it. Im happy to review and accept such PR.
from loco-adapter.
I agree. I started using XLIFF; we had problems with YML files in the past: long translations, translations with html, multiline translations etc. For now, a small update for the docs would be enough; something stating that the XLIFF is the supported and recommended format.
from loco-adapter.
Thanks
Could you send a PR to the docs?
from loco-adapter.
👍
from loco-adapter.
i disagree. It's okay if you have xliff as default format. But i expected that it will use the config output_format - which seems for me the right place
from loco-adapter.
Where should this change be made, in the loco adapter or somewhere else?
I would take a stab at an implementation PR if you can give me some pointers.
As a workaround i will remove my yml files on deploy and then download from loco. Having some sort of fallback seems usefull but i guess i should then replace the yml with xliff anyway?
from loco-adapter.
Related Issues (17)
- No HTTPlug clients found. Make sure to install a package providing "php-http/client-implementation" HOT 3
- Syncing untranslated strings makes them become blank text HOT 4
- Symfony translation domain is not being created as tag when creating translation HOT 2
- Generate assets ID from source key HOT 4
- Publish Loco adapter on http://symfony.sh/ HOT 6
- missing domains or locales
- Fuzzy translations are not considered as exportable HOT 3
- Add phraseapp-adapter repo HOT 6
- Delete does not really delete HOT 1
- Symfony 5.0 support HOT 1
- Considering symfony/http-client instead of Httplug HOT 1
- Asset not translated in this locale
- PHP 8.0 support HOT 2
- Symfony 6 support ?
- domains config not working HOT 1
- Symfony 7 support ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from loco-adapter.