Basic Guidelines for Commit Messages about phpol HOT 13 CLOSED

I agree with softening it all to a SHOULD instead of a MUST, and have it as a general guideline to keep in mind, not something that affects the actual workflow.

from phpol.

What happens if a commit message does not conform to this spec? Can/should/must a PR be rejected on that basis?

from phpol.

@naroga I think that webhooks in main repository may help us with that. What do you think?

from phpol.

@lucasmezencio I absolutely agree. Now, I'm not sure we can append this to the main proposition, as some people have already voted. Can you put this up for a vote, separately?

from phpol.

It's nice to have, but I disagree with commit messages having a strict guide.

From where I'm sit, it makes absolutely no difference. If we need rules, let's focus them where they are really important.

from phpol.

I think it is too much. We need it as a nice to have, if we go further and use it as a must have it will be a bit aggressive and scare for outside collaborators.

from phpol.

@pedrommone outside collaborators often don't read the guide lines

from phpol.

@naroga @hernandev thinking deeply, I agree that this proposal must softening to SHOULD instead of MUST.
I will close this issue and open another with modifications.

from phpol.

@naroga @lucasmezencio I can change my vote to Yes if we agree on SHOULD, not MUST

from phpol.

I've withdrawn my YES vote in favour of softening all the requirements, except language (all commits MUST be in english) to a SHOULD

from phpol.

@hernandev @pedrommone the thing I am wanting here is to avoid messages like Fix, Lalala, Another fix.

from phpol.

@everyone proposal closed. Opening another one.

from phpol.

@lucasmezencio we can required external collaborators to squash and ammend whenever they propose something like that

from phpol.