Giter VIP home page Giter VIP logo

Comments (6)

mvorisek avatar mvorisek commented on August 16, 2024

https://github.com/phpstan/phpdoc-parser/blob/1.25.0/doc/grammars/phpdoc-method.peg#L11 grammar already allows in as defined in https://github.com/phpstan/phpdoc-parser/blob/1.25.0/doc/grammars/type.abnf#L6

I wonder why the method grammar files are named *.peg instead of *.abnf and if fuzzed/tested.

from phpdoc-parser.

JanTvrdik avatar JanTvrdik commented on August 16, 2024

That has nothing to do with the type being union. It because it's a grammar conflict with static methods.

So for example, if you could use any of the following, it works just fine:

  • $this|null
  • ?static
  • null|static

from phpdoc-parser.

JanTvrdik avatar JanTvrdik commented on August 16, 2024

I tried improving the conflict resolution logic we use: #230

from phpdoc-parser.

mvorisek avatar mvorisek commented on August 16, 2024

Jan, thank you!

from phpdoc-parser.

ondrejmirtes avatar ondrejmirtes commented on August 16, 2024

Implemented #230

from phpdoc-parser.

github-actions avatar github-actions commented on August 16, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from phpdoc-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.