Booleans on both side about phpstan-strict-rules HOT 4 CLOSED

To quote the readme:

This repository contains additional rules that revolve around strictly and strongly typed code with no loose casting for those who want additional safety in extremely defensive programming.

I think that the error is self-explanatory. You should have $devMode && $configurator->loadConfig() !== null;. Or if you're using the expression as a side-effect and not as a condition in whose result you're interested in, then this would be better I think:

if ($devMode) {
    $configurator->loadConfig();
}

from phpstan-strict-rules.

Yes, the error is self-explanatory and I fixed this issue yesterday with the solution as you suggested as better :) But really don't see any risk with shortcut (in this case).

from phpstan-strict-rules.

The risk is there for anything else besides objects (things like empty string, empty array, 0, string with '0' etc.) and I value consistency.

from phpstan-strict-rules.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from phpstan-strict-rules.