Comments (5)
ondrejmirtes
commented on June 3, 2024
Hi, I don’t understand this bugreport. Please follow guidelines in
phpstan/phpstan and attach link to phpstan.org reproduction and expected
output.
On Fri, 21 Jun 2019 at 12:02, Victor Csiky ***@***.***> wrote:
I get a notice, say,
"RPC/Behavior/AttributeSerializerTrait.php (in context of class
RPC\Controller\BaseController)"
Now regardless that it is explicitly states that it is "in context of"
*blah*, *phpstan* complains that "return typehint of method" "has invalid
type RPC\Behavior\BaseAttributes".
Which is *of course* missing, given *that it is aliased/defined in
BaseController*.
Now I *surely know* that I could declare an abstract grandparent for the
abstract parent attribute classes, so that I could put it *fully
qualified* in the type hint of the method in the trait.
But it is not a question whether or not I *should* do this anyway (I did
it at times, when I had any other use for this, and sometimes even when
not; however, at times, this is just infeasible.)
The question is that *is it intentional* that the trait's aliases are not
resolved regardless of the context they are *said* to be evaluated in, or *am
I missing something*?
After all, if this is indeed intentional, this *seems* to behave
different from what PHP itself seems to do, which may be misleading.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#81?email_source=notifications&email_token=AAAZTOCMZ35R6SSP3IGMP3LP3SRL7A5CNFSM4H2PZZVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G25TDYA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAZTOE7MIMOFQTA42RLGVLP3SRL7ANCNFSM4H2PZZVA>
.
--
Ondřej Mirtes
from phpstan-strict-rules.
strongholdmedia
commented on June 3, 2024
Sure, excuse me. It is perhaps that I even posted the issue to the wrong repository (it doesn't entail strict rules at all, does it by default).
Expected output: nothing.
Actual output / case:
https://phpstan.org/r/2fef0cbd-16df-4549-af8f-ab0e1d7b19bb
Please note that with this single-file approach, the problem is not necessarily as apparent as it is when separate files are used. It is still reported nevertheless.
from phpstan-strict-rules.
strongholdmedia
commented on June 3, 2024
After a second thought, when I tick "Bleeding Edge",
https://phpstan.org/r/65ff1a02-d80a-4be0-bced-02577decc344
it suggests that PHP will use the trait's namespace when explicitly providing unqualified return types.
After checking it with PHP, at least as of 7.3.5, it seems that indeed this is what PHP does as well, though it is absolutely not documented.
So that perhaps what phpstan does is the "proper" behavior (well, the one that actually match the live one with explicit typing) and an issue should instead be filed against PHP documentation.
As such, I think I close this. Feel free to reopen should any reason for it appear.
Thanks for the great work by the way.
from phpstan-strict-rules.
ondrejmirtes
commented on June 3, 2024
The current behaviour is correct. phpDoc resolution respects the namespace and use statements in the current file. It would be really weird to change the phpDoc interpretation. It matches the behaviour of native PHP typehints.
What PHPStan means and does by analysing traits in context of each class is that if trait references a property, the analysis complains in classes that use the trait and don't have the property.
I suspect that if you're relying on your proposed behaviour, you're doing something weird and should refactor your code. Can you share what you do exactly?
from phpstan-strict-rules.
github-actions
commented on June 3, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from phpstan-strict-rules.
Related Issues (20)
- Disable all rules does not work HOT 3
- Force `@return` to match return type HOT 2
- [1.5.0] Error after added `$bleedingEdge` constructor parameter HOT 5
- display the name of the rule in the log HOT 2
- Disallow offset access on string
- Missing `#[Override]` HOT 2
- Add `uselessTrim` rule for useless `trim()`
- Relaxed booleansInConditions to allow 0, 1? HOT 5
- Add support to requireParentConstructorCall for indirect calls
- `class-string` should not be settable using string literal HOT 2
- Disallow casting potential nulls to int/string/array HOT 1
- Disallow foreach by-reference
- checkDynamicProperties, setting variable in while loop condition gets reported as might not be defined HOT 2
- Using named arguments with in_array causes a function.strict error HOT 2
- disallowedLooseComparison - allow only DateTime/DateTimeImmutable HOT 4
- Check if override method does not rename parameters
- Overriding a vendor class member with imperfect type declaration: No way to not get errors HOT 3
- Upgrade to PHP-Parser 5 HOT 5
- False positive "Variable might not be defined" after `for` loop HOT 2
- Variable property access on SimpleXMLElement
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-strict-rules.