Giter VIP home page Giter VIP logo

Comments (18)

PromoFaux avatar PromoFaux commented on August 15, 2024

Silly question, what does it look like after you refresh the page?

Also, could you provide a screenshot please? Thanks.

from adminlte.

Tom999Hall avatar Tom999Hall commented on August 15, 2024

I tried to add a screenshot, but it didn't attach - Maybe it's the Edge browser ?

from adminlte.

Tom999Hall avatar Tom999Hall commented on August 15, 2024

I've attached a screenshot to your email

from adminlte.

PromoFaux avatar PromoFaux commented on August 15, 2024

Which email address? Not seeing anything. Try hosting the screenshot on imgur and providing the link here :)

from adminlte.

Tom999Hall avatar Tom999Hall commented on August 15, 2024

(Edit - Promofaux)

Edge & IE screenshots :

image

image

from adminlte.

PromoFaux avatar PromoFaux commented on August 15, 2024

Sorry, just edited those into your comment to make it easier to see...

from adminlte.

PromoFaux avatar PromoFaux commented on August 15, 2024

OK, so I've just tested this on Chrome, Firefox and IE 11, though I don't have edge installed...

The graphs all look fine on first load, but there is (a known) issue when you resize the page, in which the elements don't resize correctly, however a refresh will make them circular again.

from adminlte.

Tom999Hall avatar Tom999Hall commented on August 15, 2024

Just re-tested IE/Chrome/Edge - initial page load still not circular, but refreshing the page made them circular again
Btw - this is on Windows 10 Build 14361

from adminlte.

PromoFaux avatar PromoFaux commented on August 15, 2024

Hmm, I'm on build 10240 (Enterprise) And am not experiencing this.. Weird. Would be interesting to see if anyone else has this issue. You say you didn't have this issue before 2.7? As far as I'm aware there were no changes made to that page. @Mcat12 any ideas?

from adminlte.

Tom999Hall avatar Tom999Hall commented on August 15, 2024

I always open my browser windows maximised, so I'm not re-sizing

I definitely haven't seen this with 2.6 on earlier builds, but then 2.7 & 14361 were quite close time-wise, so I may just have not noticed any issues with 2.6 & 14361

But at least it's a known issue & a refresh fixes it

from adminlte.

PromoFaux avatar PromoFaux commented on August 15, 2024

It's either a fault with charts.js or something we're doing wrong with it!

from adminlte.

AzureMarker avatar AzureMarker commented on August 15, 2024

I didn't change anything with relation to the graphs. (As far as I can remember)

from adminlte.

DonLexos avatar DonLexos commented on August 15, 2024

Just tested this on win10 in Chrome and Edge. On initial load the charts are perfectly round. A resize in Edge would transform them (based on what direction you resize the window), same in Chrome.

from adminlte.

Tom999Hall avatar Tom999Hall commented on August 15, 2024

(sorry, screenshots are still not uploading for me)

Thanks for that Alex - but (for me), the charts are still non-circular

Interestingly though, it’s only if I click the “Refresh” button that the charts go circular again

If I click the “Restore Down” button, then Maximise again (or double-click the Title Bar), or re-type the URL & hit Enter, they remain non-circular
Likewise if I “Restore Down”, and grab the edge of the window and resize manually (vertically or horizontally),
the charts distort depending on the current shape of the window, but once I Maximise again, they remain non-circular

It wouldn’t be a Display driver issue would it ?

from adminlte.

AzureMarker avatar AzureMarker commented on August 15, 2024

Does this happen on all browsers?

from adminlte.

Tom999Hall avatar Tom999Hall commented on August 15, 2024

The initial misshapen charts - yes - (on Edge, the built-in IE, and Chrome x64)

So far I've only tried the extra actions (Maximise, Restore down, etc), on Edge

I'm not at home at the moment but I will try later on Chrome & IE

Get Outlook for Android

From: Mcat12

Sent: Tuesday, 14 June, 16:23

Subject: Re: [pi-hole/AdminLTE] Admin Console Pie-charts are no longer "circular" (#99)

To: pi-hole/AdminLTE

Cc: Tom999Hall, Comment

Does this happen on all browsers?

You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

from adminlte.

Tom999Hall avatar Tom999Hall commented on August 15, 2024

I'm baaack ! - while I was away, a new Windows 10 build: 14366 dropped - I've clean-installed it, and here's what I'm seeing
Edge - initial view, charts are stretched vertically, restore-down & grab to resize deforms charts according to window shape & size, maximise still remain non-circular - reload url - charts are stretched restore button: charts return to circular
Built-in IE - (same as Edge)
Chrome x64 - initial view, charts are circular !, restore-down & grab to resize deforms charts according to window shape & size, maximise: charts return to circular, reload url - still circular

I hope this helps ?

from adminlte.

DL6ER avatar DL6ER commented on August 15, 2024

We have updated the Chart.js engine to the latest version. There have been many changes. I think everything should have been fixed. I don't use a Windows machine, so I cannot do these tests myself.

However, @Tom999Hall feel free to reopen this issue if it will not be fixed in the next release.

from adminlte.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.