Giter VIP home page Giter VIP logo

Comments (9)

vktr avatar vktr commented on May 15, 2024

Hi, you are missing the Visual C++ 2015 runtime. Microsoft recommends against linking statically against the runtime.

I will include them in the installer in an upcoming version :)

from picotorrent.

ValdasK avatar ValdasK commented on May 15, 2024

Casual users do not install Visual Studio to their PCs, therefore they will get this error and are most likely to quit instead of having to go through hassle of installing run-time. If MS does not recommend to link it, then what is the standard practice with those?

from picotorrent.

vktr avatar vktr commented on May 15, 2024

One way is to include the Visual C++ runtime merge module in the installer, which would install the runtime alongside the application. I've just not gotten there yet.

from picotorrent.

ValdasK avatar ValdasK commented on May 15, 2024

Great job on the application, you can close this issue if needed. Thanks!

from picotorrent.

vktr avatar vktr commented on May 15, 2024

I'll keep it open until the installer is distributing the runtime, thanks for reporting it.

from picotorrent.

 avatar commented on May 15, 2024

@vktr does PicoTorrent actually use some of the newer APIs for this to really be a dependency? For example the Golang compiler builds EXEs that rely on Visual C++ 6, so that they will work with out of the box Windows 7+:

http://github.com/svnpenn/sage/tree/6f0fd05/go

Compiling PicoTorrent with Visual C++ 14/2015 should only be done if you are utilizing some new WINAPI methods, otherwise you are putting out your users for no reason

from picotorrent.

vktr avatar vktr commented on May 15, 2024

Hi @svnpenn! The choice to use MSVC14 comes from the fact that it supports much of the C++14 standard, and has generally better support for C++11 as well. The MSVC version does mot mandate which WINAPI version you use, that us up to the developer and depends in part on what defines you use - i.e you can target Windows XP by defining _WIN32_WINNT=0x0501, and still use MSVC14.

What I think you're getting at is that Windows 7 already bundles the VC++6 runtime which would make a dependency less for PicoTorrent - but then we cannot use the new features in C++14.

Running the PicoTorrent installer will download and install the required MSVC14 runtime at install time, and that makes PicoTorrent work out of the box on Windows 7 as well. Windows 7 (both x86 and x64) is the platform I test all releases on before putting them on GitHub.

Hope that clarifies it a bit! 😄

from picotorrent.

 avatar commented on May 15, 2024

@vktr note there is a new version

http://microsoft.com/download/details.aspx?id=49984

from picotorrent.

vktr avatar vktr commented on May 15, 2024

@svnpenn We've been using it since it was released 😄

from picotorrent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.