Giter VIP home page Giter VIP logo

Comments (17)

piitaya avatar piitaya commented on May 16, 2024 3

It should be fixed in the 1.9.0 beta version. Can you confirm it works now ?
@gmac0612 @Eivind-V @bernikr @dafer94 @nelsonamen

from lovelace-mushroom.

nelsonamen avatar nelsonamen commented on May 16, 2024 1

It works!! 👍

from lovelace-mushroom.

bernikr avatar bernikr commented on May 16, 2024 1

It's fixed now. Thanks!!

from lovelace-mushroom.

piitaya avatar piitaya commented on May 16, 2024

I tested :

  • Vibrate option "on" : vibrate when I toggle a switch or a lamp
  • Vibrate option "off" : does not vibrate when I toggle a switch or a lamp

It's the native thing from home assistant toggle service, not a Mushroom feature.

from lovelace-mushroom.

bernikr avatar bernikr commented on May 16, 2024

I have the same problem, that even with vibration turned "off" in the options the cards will vibrate on toggle.

from lovelace-mushroom.

bernikr avatar bernikr commented on May 16, 2024

It's the native thing from home assistant toggle service, not a Mushroom feature.

Its not native to the home assistants toggle service, but to the custom-card-helper handleAction method.

I've raised an issue there: custom-cards/custom-card-helpers#61

I hope this can be resolved. I would really like to use the mushroom cards, but having my phone vibrate for 0.5 seconds every time I toggle something is not really the best experience.

from lovelace-mushroom.

piitaya avatar piitaya commented on May 16, 2024

Can you provide some details about your phone/android version/HA Android version ? I have no issue with my OnePlus 8. So I unable to reproduce ce bug.

from lovelace-mushroom.

bernikr avatar bernikr commented on May 16, 2024

Sure:
Phone: Huawei Mate 20 (HMA-L29)
Android Version: 10
HA Version: 2022.3.8
App Version: 2022.3.0-full

I also noticed that the vibration changes depending if they are turned on or turned off/phone is in "do not disturb" mode. When the vibrations are turned off it changes from two short pulses to a single 500ms pulse, which is way more annoying.

I suspect that there is a bug in the android app itself, since I found code there that is responsible for a 500ms vibration. I've also raised an issue there: home-assistant/android#2430

from lovelace-mushroom.

piitaya avatar piitaya commented on May 16, 2024

I looked into the custom-card-helpers and the home-assistant-frontend code. Custom card helpers use success haptics while HA native cards use light ones.

from lovelace-mushroom.

bernikr avatar bernikr commented on May 16, 2024

I saw that and wrote that into the issue i opened there. However, I think it is mostly a problem with the android app under certain conditions, as disabling vibrations works well in the mobile browser. Lets hope it gets fixed there soon.

from lovelace-mushroom.

bernikr avatar bernikr commented on May 16, 2024

You could btw use handleClick instead of handleAction of the custom-card-helpers. It has a slightly different function signature (two booleans instead of one string for the action), but allows the user to define a haptics setting, instead of always emitting a success event on toggle or service call.

from lovelace-mushroom.

piitaya avatar piitaya commented on May 16, 2024

custom-card-helpers is no longer maintained. I will import the handle-action into mushroom to keep it updated with home assistant action.

from lovelace-mushroom.

bernikr avatar bernikr commented on May 16, 2024

After a bit more code reading and long discussion (home-assistant/android#2430), i think the problem is that the custom-card-helpers emit their haptics directly on the window, while all native HA cards emit it on their respective DOM element. I still don't understand the chain of bugs and undocumented things that lead to this strange behavior in the end, but this seems to be the only difference on how native HA cards and custom-card-helpers implement the haptics.

from lovelace-mushroom.

gmac0612 avatar gmac0612 commented on May 16, 2024

I have tried this today and encountered similar behaviour. Haptic setting in companion app is not respected & all taps provide a long 'success' vibration.

HA and companion app both latest stable as of time of writing, handset is a Samsung Galaxy S8+

I'd be very happy to see this fixed as the cards are perfect apart from this issue.

from lovelace-mushroom.

dafer94 avatar dafer94 commented on May 16, 2024

I am suffering the same behaviour described by Bernikr a few comments above, also with the same Huawei device: The haptics for custom cards does not turn off when the app toggle is disabled, they just change from two shorts pulses to a long one.

I have also tested it with an older device (OnePlus 3). The exact same dashboard with the same app settings and it works just fine.

Have somebody found a workaround for this? Maybe a dashboard setting that makes it quiet and prevent its inner cards from generating haptic feedback.

from lovelace-mushroom.

nelsonamen avatar nelsonamen commented on May 16, 2024

Same problem, ONLY in mushrooms, vibrations always on

from lovelace-mushroom.

filikun avatar filikun commented on May 16, 2024

This seems to be the same on iPhone. Code below does not work either.

        tap_action:
          action: call-service
          service: input_select.select_option
          haptic: none
          service_data:
            entity_id: input_select.chart_time_span
            option: day

from lovelace-mushroom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.