Giter VIP home page Giter VIP logo

Comments (5)

abdelrhmanyosry avatar abdelrhmanyosry commented on June 12, 2024 1

@fashxp can i extend the built-in class in data-importer and in case i didn't find the value in the select input, i can just set it as empty.

from pimcore.

fashxp avatar fashxp commented on June 12, 2024

but then you would have no chance of knowing, that in DB there is actually a invalid value, right?

from pimcore.

abdelrhmanyosry avatar abdelrhmanyosry commented on June 12, 2024

@fashxp It doesn't matter from my perspective if I entered the wrong value just displays the empty value in the select option. I can review data-import logs to see if I entered the incorrect value for this attribute. Still, an invalid pop message is annoying for my client especially since we have many select options attributes. Hence, in case I entered 3-4 wrong values I get 4 different invalid option messages so when the client displays the object he should click for time on the message above not a good practice. I think it will be better if the invalid-option message has more info so I can detect which attribute causes the problem.

from pimcore.

fashxp avatar fashxp commented on June 12, 2024

with having a better error message I fully agree! But we should not ignore that case completely.

from pimcore.

github-actions avatar github-actions commented on June 12, 2024

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

from pimcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.